Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fastpath in asyncio.sleep if delay<0 #76532

Closed
asvetlov opened this issue Dec 17, 2017 · 2 comments
Closed

Use fastpath in asyncio.sleep if delay<0 #76532

asvetlov opened this issue Dec 17, 2017 · 2 comments
Labels
3.7 expert-asyncio performance stdlib

Comments

@asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Dec 17, 2017

BPO 32351
Nosy @asvetlov, @1st1
PRs
  • #4908
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2017-12-17.14:42:09.626>
    created_at = <Date 2017-12-17.12:22:02.663>
    labels = ['3.7', 'expert-asyncio', 'library', 'performance']
    title = 'Use fastpath in asyncio.sleep if delay<0'
    updated_at = <Date 2017-12-17.14:42:09.625>
    user = 'https://github.com/asvetlov'

    bugs.python.org fields:

    activity = <Date 2017-12-17.14:42:09.625>
    actor = 'asvetlov'
    assignee = 'none'
    closed = True
    closed_date = <Date 2017-12-17.14:42:09.626>
    closer = 'asvetlov'
    components = ['Library (Lib)', 'asyncio']
    creation = <Date 2017-12-17.12:22:02.663>
    creator = 'asvetlov'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 32351
    keywords = ['patch']
    message_count = 2.0
    messages = ['308487', '308489']
    nosy_count = 2.0
    nosy_names = ['asvetlov', 'yselivanov']
    pr_nums = ['4908']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'performance'
    url = 'https://bugs.python.org/issue32351'
    versions = ['Python 3.7']

    @asvetlov
    Copy link
    Contributor Author

    @asvetlov asvetlov commented Dec 17, 2017

    Currently asyncio.sleep schedules a callback execution by loop.call_later() call, which has the same behavior but 2x slower.

    @asvetlov asvetlov added 3.7 stdlib expert-asyncio labels Dec 17, 2017
    @asvetlov
    Copy link
    Contributor Author

    @asvetlov asvetlov commented Dec 17, 2017

    New changeset 5382c05 by Andrew Svetlov in branch 'master':
    bpo-32351: Use fastpath in asyncio.sleep if delay<0 (bpo-4908)
    5382c05

    @asvetlov asvetlov added the performance label Dec 17, 2017
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 expert-asyncio performance stdlib
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant