Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StreamWriter.wait_closed() #76572

Closed
asvetlov opened this issue Dec 20, 2017 · 3 comments
Closed

Add StreamWriter.wait_closed() #76572

asvetlov opened this issue Dec 20, 2017 · 3 comments
Labels
3.7 expert-asyncio stdlib type-feature

Comments

@asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Dec 20, 2017

BPO 32391
Nosy @njsmith, @asvetlov, @1st1, @nitishch
PRs
  • #5281
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2018-01-24.23:21:26.170>
    created_at = <Date 2017-12-20.19:12:25.492>
    labels = ['3.7', 'type-feature', 'library', 'expert-asyncio']
    title = 'Add StreamWriter.wait_closed()'
    updated_at = <Date 2018-01-24.23:21:26.169>
    user = 'https://github.com/asvetlov'

    bugs.python.org fields:

    activity = <Date 2018-01-24.23:21:26.169>
    actor = 'asvetlov'
    assignee = 'none'
    closed = True
    closed_date = <Date 2018-01-24.23:21:26.170>
    closer = 'asvetlov'
    components = ['Library (Lib)', 'asyncio']
    creation = <Date 2017-12-20.19:12:25.492>
    creator = 'asvetlov'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 32391
    keywords = ['patch']
    message_count = 3.0
    messages = ['308780', '308781', '310640']
    nosy_count = 4.0
    nosy_names = ['njs', 'asvetlov', 'yselivanov', 'nitishch']
    pr_nums = ['5281']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue32391'
    versions = ['Python 3.7']

    @asvetlov
    Copy link
    Contributor Author

    @asvetlov asvetlov commented Dec 20, 2017

    Without the method there is no possibility to wait for actual writer closing (it's performed at least on next loop iteration, and even later for SSL transports).

    Without waiting for actual closing writing tests is a pain: user should either add asyncio.sleep() after writer closing or suppress many warnings about unclosed resources.

    @asvetlov asvetlov added 3.7 stdlib expert-asyncio labels Dec 20, 2017
    @1st1
    Copy link
    Member

    @1st1 1st1 commented Dec 20, 2017

    We've discussed this before, please go ahead.

    @1st1 1st1 added the type-feature label Dec 20, 2017
    @asvetlov
    Copy link
    Contributor Author

    @asvetlov asvetlov commented Jan 24, 2018

    New changeset fe133aa by Andrew Svetlov in branch 'master':
    bpo-32391: Implement StreamWriter.wait_closed() (bpo-5281)
    fe133aa

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 expert-asyncio stdlib type-feature
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants