Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and add new tests for the f_lineno setter #76597

Closed
serhiy-storchaka opened this issue Dec 23, 2017 · 7 comments
Closed

Refactor and add new tests for the f_lineno setter #76597

serhiy-storchaka opened this issue Dec 23, 2017 · 7 comments
Labels
3.7 tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Dec 23, 2017

BPO 32416
Nosy @serhiy-storchaka
PRs
  • bpo-32416: Refactor tests for the f_lineno setter and add new tests. #4991
  • [3.6] bpo-32416: Refactor tests for the f_lineno setter and add new tests. (GH-4991). #5016
  • [2.7] bpo-32416: Refactor tests for the f_lineno setter and add new tests. (GH-4991). #5017
  • bpo-32416: Add two new tests in test_sys_settrace. #5072
  • [3.6] bpo-32416: Add two new tests in test_sys_settrace. (GH-5072) #5073
  • [2.7] bpo-32416: Add two new tests in test_sys_settrace. (GH-5072) #5074
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2017-12-27.19:37:42.172>
    created_at = <Date 2017-12-23.17:14:03.247>
    labels = ['3.7', 'type-feature', 'tests']
    title = 'Refactor and add new tests for the f_lineno setter'
    updated_at = <Date 2018-01-01.18:51:33.000>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2018-01-01.18:51:33.000>
    actor = 'serhiy.storchaka'
    assignee = 'none'
    closed = True
    closed_date = <Date 2017-12-27.19:37:42.172>
    closer = 'serhiy.storchaka'
    components = ['Tests']
    creation = <Date 2017-12-23.17:14:03.247>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 32416
    keywords = ['patch']
    message_count = 7.0
    messages = ['308959', '309067', '309099', '309100', '309340', '309342', '309343']
    nosy_count = 1.0
    nosy_names = ['serhiy.storchaka']
    pr_nums = ['4991', '5016', '5017', '5072', '5073', '5074']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue32416'
    versions = ['Python 2.7', 'Python 3.6', 'Python 3.7']

    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Dec 23, 2017

    Proposed PR refactors existing tests for the f_lineno setter and adds few new tests. This will help to avoid regressions in bpo-17611.

    I have found that some illegal jumps are not prohibited. They can lead to crashes or weird behavior. For example jumps to or from the bare except block. This will be fixed in a separate issue.

    @serhiy-storchaka serhiy-storchaka added 3.7 tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Dec 23, 2017
    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Dec 26, 2017

    New changeset 53f9135 by Serhiy Storchaka in branch 'master':
    bpo-32416: Refactor tests for the f_lineno setter and add new tests. (bpo-4991)
    53f9135

    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Dec 27, 2017

    New changeset ea98eba by Serhiy Storchaka in branch '3.6':
    [3.6] bpo-32416: Refactor tests for the f_lineno setter and add new tests. (GH-4991). (bpo-5016)
    ea98eba

    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Dec 27, 2017

    New changeset c60eca0 by Serhiy Storchaka in branch '2.7':
    [2.7] bpo-32416: Refactor tests for the f_lineno setter and add new tests. (GH-4991). (bpo-5017)
    c60eca0

    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Jan 1, 2018

    New changeset e8ed965 by Serhiy Storchaka in branch 'master':
    bpo-32416: Add two new tests in test_sys_settrace. (bpo-5072)
    e8ed965

    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Jan 1, 2018

    New changeset 2de47ca by Serhiy Storchaka (Miss Islington (bot)) in branch '2.7':
    bpo-32416: Add two new tests in test_sys_settrace. (GH-5072) (bpo-5074)
    2de47ca

    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Jan 1, 2018

    New changeset 439ce8a by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6':
    bpo-32416: Add two new tests in test_sys_settrace. (GH-5072) (bpo-5073)
    439ce8a

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant