UUID Module - FreeBSD build failure

[dcarlier-afilias]

BPO	32493
Nosy	@warsaw, @pitrou, @vstinner, @ned-deily, @serhiy-storchaka, @koobs, @aixtools, @dcarlier-afilias, @devnexen, @miss-islington
PRs	bpo-32493: [3.7] UUID module. Not only AIX, but FreeBSD has uid_create support #5089 bpo-32493: Fix uuid.uuid1() on FreeBSD. #7098 bpo-32493: Fix uuid.uuid1() on FreeBSD. #7099 [3.7] bpo-32493: Fix uuid.uuid1() on FreeBSD. (GH-7099) #7104 bpo-28009: for AIX correct uuid.getnode() and add ctypes() based uuid._generate_time_safe #5183 bpo-32493: Fix the detection of uuid_enc_be() function of libuuid in configure. #7511 bpo-32493: Correct test for uuid_enc_be availability in configure.ac. #7567

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-06-09.22:46:36.161>
created_at = <Date 2018-01-04.18:57:50.582>
labels = ['3.7', '3.8']
title = 'UUID Module - FreeBSD build failure'
updated_at = <Date 2018-06-11.11:30:30.511>
user = 'https://github.com/dcarlier-afilias'

bugs.python.org fields:

activity = <Date 2018-06-11.11:30:30.511>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2018-06-09.22:46:36.161>
closer = 'ned.deily'
components = ['FreeBSD']
creation = <Date 2018-01-04.18:57:50.582>
creator = 'David Carlier'
dependencies = []
files = []
hgrepos = []
issue_num = 32493
keywords = ['patch']
message_count = 39.0
messages = ['309479', '309505', '309506', '309661', '309662', '309663', '309666', '309702', '309728', '309729', '310147', '310148', '310186', '310190', '310192', '310194', '310449', '310501', '311469', '311547', '313011', '313116', '313117', '317526', '317528', '317582', '317592', '317635', '317642', '317644', '319024', '319025', '319072', '319181', '319182', '319183', '319210', '319244', '319294']
nosy_count = 10.0
nosy_names = ['barry', 'pitrou', 'vstinner', 'ned.deily', 'serhiy.storchaka', 'koobs', 'Michael.Felt', 'David Carlier', 'devnexen', 'miss-islington']
pr_nums = ['5089', '7098', '7099', '7104', '5183', '7511', '7567']
priority = None
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue32493'
versions = ['Python 3.7', 'Python 3.8']

[dcarlier-afilias]

UUID module build fails on FreeBSD since it supports uuid_create function.

[pitrou]

The AIX-specific code was contributed by Michael Felt in bpo-32399.

[pitrou]

Michael, does AIX have uint32_t? If so, we could happily drop the unsigned32 reference.

[aixtools]

On 05/01/2018 13:38, Antoine Pitrou wrote:

Antoine Pitrou <pitrou@free.fr> added the comment:

Michael, does AIX have uint32_t? If so, we could happily drop the unsigned32 reference.

Yes, AIX has unit32_t.

michael@x071:[/home/michael]grep unsigned32 /usr/include/.h
/usr/include/sys/.h | grep typed
/usr/include/uuid.h:typedef u_int32_t unsigned32;      /* positive 32
bit integer */
/usr/include/uuid.h:typedef unsigned32 boolean32;

----------

---

Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue32493\>

---

[pitrou]

Seems to be in inttypes.h:
https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/com.ibm.aix.files/inttypes.h.htm

[dcarlier-afilias]

Perfect. That solves in the process OpenBSD uuid module build too.

[aixtools]

On 08/01/2018 12:47, David Carlier wrote:

David Carlier <dcarlier@afilias.info> added the comment:

Perfect. That solves in the process OpenBSD uuid module build too.

----------
p.s. I did not 'invent' unsigned32 - just took the syntax from the man
page:
https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/com.ibm.aix.basetrf2/uuid_create.htm

• and I just did the grep above to show the type existed AND was
  directly related to unsigned32 - even in AIX include files.

---

Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue32493\>

---

[dcarlier-afilias]

I guessed that :-) I trusted it worked just fine for you. To be honest I know nearly nothing about AIX specificities :-)

[pitrou]

New changeset b4ebaa7 by Antoine Pitrou (David Carlier) in branch 'master':
bpo-32493: Not only AIX, but FreeBSD has uuid_create support (bpo-5089)
b4ebaa7

[pitrou]

Thank you for the fix David!

[vstinner]

New changeset b4ebaa7 by Antoine Pitrou (David Carlier) in branch 'master':
bpo-32493: Not only AIX, but FreeBSD has uuid_create support (bpo-5089)

This change introduced a regression on AMD64 FreeBSD 10.x Shared 3.x:

http://buildbot.python.org/all/#/builders/87/builds/463

======================================================================
FAIL: test_uuid1 (test.test_uuid.TestUUIDWithExtModule)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.x.koobs-freebsd10/build/Lib/test/test_uuid.py", line 320, in test_uuid1
    equal(u.version, 1)
AssertionError: 14 != 1

[devnexen]

Might comes from uuid1 function itself ... e.g. line 704 not setting version "field".