Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solaris "stat" should support "st_fstype" #76840

Closed
jcea opened this issue Jan 25, 2018 · 3 comments
Closed

Solaris "stat" should support "st_fstype" #76840

jcea opened this issue Jan 25, 2018 · 3 comments
Assignees
Labels
3.7 type-feature

Comments

@jcea
Copy link
Member

@jcea jcea commented Jan 25, 2018

BPO 32659
Nosy @jcea, @iritkatriel
PRs
  • #5307
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/jcea'
    closed_at = <Date 2020-10-27.14:57:48.251>
    created_at = <Date 2018-01-25.00:46:54.225>
    labels = ['type-feature', '3.7']
    title = 'Solaris "stat" should support "st_fstype"'
    updated_at = <Date 2020-10-27.14:57:48.251>
    user = 'https://github.com/jcea'

    bugs.python.org fields:

    activity = <Date 2020-10-27.14:57:48.251>
    actor = 'vstinner'
    assignee = 'jcea'
    closed = True
    closed_date = <Date 2020-10-27.14:57:48.251>
    closer = 'vstinner'
    components = []
    creation = <Date 2018-01-25.00:46:54.225>
    creator = 'jcea'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 32659
    keywords = ['patch']
    message_count = 3.0
    messages = ['310650', '310945', '378731']
    nosy_count = 2.0
    nosy_names = ['jcea', 'iritkatriel']
    pr_nums = ['5307']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue32659'
    versions = ['Python 3.7']

    @jcea
    Copy link
    Member Author

    @jcea jcea commented Jan 25, 2018

    Solaris has an extra "st_fstype" in the "stat" structure:

    """
    st_fstype
    A null-teminated string that uniquely identifies the type
    of the filesystem that contains the file.
    """

    Supporting this should be trivial and 3.7RC1 is still a week away. I can take care of the patch for Python 3.7, if you agree that this must be fixed.

    @jcea jcea added the 3.7 label Jan 25, 2018
    @jcea jcea self-assigned this Jan 25, 2018
    @jcea jcea added the type-feature label Jan 25, 2018
    @jcea
    Copy link
    Member Author

    @jcea jcea commented Jan 28, 2018

    New changeset 6c51d51 by jcea in branch 'master':
    bpo-32659: Solaris "stat" should support "st_fstype" (bpo-5307)
    6c51d51

    @iritkatriel
    Copy link
    Member

    @iritkatriel iritkatriel commented Oct 16, 2020

    This seems complete, can it be closed?

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 type-feature
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants