dbm.open() encodes filename with default encoding rather than the filesystem encoding

[JoshFriend]

BPO	32922
Nosy	@arigo, @serhiy-storchaka, @miss-islington, @iritkatriel
PRs	bpo-32922: dbm.open() now encodes filename with the filesystem encoding. #5832 [3.7] bpo-32922: dbm.open() now encodes filename with the filesystem encoding. (GH-5832) #5905 [3.6] bpo-32922: dbm.open() now encodes filename with the filesystem encoding. (GH-5832). #5906

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2020-10-04.16:29:39.358>
created_at = <Date 2018-02-23.15:11:08.664>
labels = ['3.7', '3.8', 'type-bug', 'library']
title = 'dbm.open() encodes filename with default encoding rather than the filesystem encoding'
updated_at = <Date 2020-10-04.16:29:39.357>
user = 'https://bugs.python.org/JoshFriend'

bugs.python.org fields:

activity = <Date 2020-10-04.16:29:39.357>
actor = 'Josh Friend'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2020-10-04.16:29:39.358>
closer = 'Josh Friend'
components = ['Library (Lib)']
creation = <Date 2018-02-23.15:11:08.664>
creator = 'Josh Friend'
dependencies = []
files = []
hgrepos = []
issue_num = 32922
keywords = ['patch']
message_count = 8.0
messages = ['312636', '312649', '312664', '312925', '312927', '312977', '377942', '377960']
nosy_count = 5.0
nosy_names = ['arigo', 'serhiy.storchaka', 'Josh Friend', 'miss-islington', 'iritkatriel']
pr_nums = ['5832', '5905', '5906']
priority = 'normal'
resolution = None
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue32922'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

[JoshFriend]

Armin Rigo from the PyPy project pointed this out to me: https://bitbucket.org/pypy/pypy/issues/2755/dbmopen-expects-a-str-for-filename-throws

This could probably lead to some weird behavior given the right filename

[serhiy-storchaka]

PR 5832 fixes dbm.ndbm.open() and dbm.gdbm.open(). dbm.dumb.open() already used the filesystem encoding.

I don't think anything should be fixed in 2.7. Supporting Unicode filenames looks like a new feature.

[arigo]

It's not a new feature. See for example all functions from posixmodule.c: it should at least be PyArg_ParseTuple(args, "et", Py_FileSystemDefaultEncoding, &char_star_variable).

[serhiy-storchaka]

New changeset 6f600ff by Serhiy Storchaka in branch 'master':
bpo-32922: dbm.open() now encodes filename with the filesystem encoding. (GH-5832)
6f600ff

[miss-islington]

New changeset a9e0b07 by Miss Islington (bot) in branch '3.7':
bpo-32922: dbm.open() now encodes filename with the filesystem encoding. (GH-5832)
a9e0b07

[serhiy-storchaka]

New changeset 5bf7485 by Serhiy Storchaka in branch '3.6':
[3.6] bpo-32922: dbm.open() now encodes filename with the filesystem encoding. (GH-5832). (GH-5906)
5bf7485

[iritkatriel]

This seems resolved, can it be closed?

[JoshFriend]

yes it should be closed, can i do that? (ill try...)