Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jumping out of "with" block #77207

Closed
serhiy-storchaka opened this issue Mar 8, 2018 · 6 comments
Closed

Fix jumping out of "with" block #77207

serhiy-storchaka opened this issue Mar 8, 2018 · 6 comments
Labels
3.7 3.8 interpreter-core Interpreter core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Mar 8, 2018

BPO 33026
Nosy @pitrou, @serhiy-storchaka
PRs
  • bpo-33026: Fix jumping out of "with" block by setting f_lineno. #6026
  • [3.7] bpo-33026: Fix jumping out of "with" block by setting f_lineno. (GH-6026). #6074
  • [3.6] [3.7] bpo-33026: Fix jumping out of "with" block by setting f_lineno. (GH-6074) #6075
  • [2.7] [3.7] bpo-33026: Fix jumping out of "with" block by setting f_lineno. (GH-6074) #6076
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2018-03-11.08:56:24.974>
    created_at = <Date 2018-03-08.07:46:38.708>
    labels = ['interpreter-core', '3.7', '3.8', 'type-crash']
    title = 'Fix jumping out of "with" block'
    updated_at = <Date 2018-03-11.08:56:24.973>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2018-03-11.08:56:24.973>
    actor = 'serhiy.storchaka'
    assignee = 'none'
    closed = True
    closed_date = <Date 2018-03-11.08:56:24.974>
    closer = 'serhiy.storchaka'
    components = ['Interpreter Core']
    creation = <Date 2018-03-08.07:46:38.708>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 33026
    keywords = ['patch']
    message_count = 6.0
    messages = ['313426', '313427', '313582', '313585', '313586', '313589']
    nosy_count = 2.0
    nosy_names = ['pitrou', 'serhiy.storchaka']
    pr_nums = ['6026', '6074', '6075', '6076']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'crash'
    url = 'https://bugs.python.org/issue33026'
    versions = ['Python 2.7', 'Python 3.6', 'Python 3.7', 'Python 3.8']

    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Mar 8, 2018

    The proposed PR fixes jumping from "with" block. Currently the exit function is left on the stack.

    This fix is for 3.8 only. 3.7 and older versions are affected by this bug, but since the code was significantly changed in 3.8, I'm not sure it will be so easy to fix it in older versions.

    @serhiy-storchaka serhiy-storchaka added 3.8 interpreter-core Interpreter core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump labels Mar 8, 2018
    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Mar 8, 2018

    Well, it is not hard to fix this in older versions.

    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Mar 11, 2018

    New changeset 26c9f56 by Serhiy Storchaka in branch 'master':
    bpo-33026: Fix jumping out of "with" block by setting f_lineno. (bpo-6026)
    26c9f56

    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Mar 11, 2018

    New changeset 04aadf2 by Serhiy Storchaka in branch '3.7':
    [3.7] bpo-33026: Fix jumping out of "with" block by setting f_lineno. (GH-6026). (bpo-6074)
    04aadf2

    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Mar 11, 2018

    New changeset 20ac11a by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6':
    [3.6] bpo-33026: Fix jumping out of "with" block by setting f_lineno. (GH-6026). (GH-6074) (GH-6075)
    20ac11a

    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Mar 11, 2018

    New changeset 3854f58 by Serhiy Storchaka (Miss Islington (bot)) in branch '2.7':
    [2.7] bpo-33026: Fix jumping out of "with" block by setting f_lineno. (GH-6026). (GH-6074) (GH-6076)
    3854f58

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 3.8 interpreter-core Interpreter core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant