-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
[imaplib] MOVE is a legal command #77517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
When running box = IMAP4_SSL(host)
box.login(user, pass)
msgs = somehowget_uids_of_messsages_to_move()
box.uid('MOVE', msgs, 'target') I get an error "Unknown IMAP4 UID command: MOVE". The problem is that imaplib contains a list Commands of the permitted IMAP commands, and MOVE is not included, even though it is perfectly legal (and quite widely supported) command according to RFC-6851. |
https://tools.ietf.org/html/rfc6851 |
Should we also add the MOVE command to Python 2.7, 3.6 and 3.7? The change looks safe and trivial. |
IMHO it's ok to backport this change. The stdlib must follow evolutions of the IMAP protocol. It's a self contained and safe change, it's not a new Python method. |
See also bpo-33327: Add a method to move messages to IMAPlib. |
Fuck you |
Matěj Cepl: There is a bot to backport changes to other branches. I closed your backport PRs. I prefer to polish the change for the master branch, and only backport later. For example, I modified the commit message of your PR. The bot also uses "git cherry-pick -x" to mention the sha1 of the backported commit which helps to track the origin of backports. |
I don't think that "git cherry-pick -x" can be used before a PR is merged, since the merge changes the SHA1 (using our current workflow). |
Matěj Cepl: Thanks for your change. I applied it to 2.7, 3.6, 3.7 and master branches. |
Anthony Singleton: "Fuck you" What does justify this verbal violence? |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: