leak in set_symmetric_difference?

[lekma]

BPO	33391
Nosy	@rhettinger, @vstinner, @lekma, @methane, @serhiy-storchaka, @miss-islington
PRs	bpo-33391: fix leak in set_symmetric_difference #6670 bpo-33391: fix leak in set_symmetric_difference #6671 bpo-33391: fix leak in set_symmetric_difference #6672 [3.7] bpo-33391: Fix refleak in set_symmetric_difference (GH-6670) #6690 [3.6] bpo-33391: Fix refleak in set_symmetric_difference (GH-6670) #6691 [2.7] bpo-33391: Fix refleak in set_symmetric_difference (GH-6670) #6692
Files	setobject.c.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/rhettinger'
closed_at = <Date 2018-05-02.10:35:58.911>
created_at = <Date 2018-04-30.09:42:42.562>
labels = ['interpreter-core', 'type-bug', '3.8']
title = 'leak in set_symmetric_difference?'
updated_at = <Date 2018-05-03.02:43:22.730>
user = 'https://github.com/lekma'

bugs.python.org fields:

activity = <Date 2018-05-03.02:43:22.730>
actor = 'methane'
assignee = 'rhettinger'
closed = True
closed_date = <Date 2018-05-02.10:35:58.911>
closer = 'methane'
components = ['Interpreter Core']
creation = <Date 2018-04-30.09:42:42.562>
creator = 'lekma'
dependencies = []
files = ['47557']
hgrepos = []
issue_num = 33391
keywords = ['patch']
message_count = 10.0
messages = ['315945', '315947', '315951', '315988', '316058', '316062', '316064', '316066', '316094', '316101']
nosy_count = 6.0
nosy_names = ['rhettinger', 'vstinner', 'lekma', 'methane', 'serhiy.storchaka', 'miss-islington']
pr_nums = ['6670', '6671', '6672', '6690', '6691', '6692']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue33391'
versions = ['Python 3.8']

[lekma]

shouldn't otherset be decrefed before returning on error in set_symmetric_difference? if not, what am I missing?

[serhiy-storchaka]

Good catch! Do you mind to create a pull request on GitHub?

[vstinner]

I don't think that an unit test is needed, and I failed to write such test :-)

[lekma]

Good catch! Do you mind to create a pull request on GitHub?
done

[methane]

New changeset 491bbed by INADA Naoki (lekma) in branch 'master':
bpo-33391: Fix refleak in set_symmetric_difference (GH-6670)
491bbed

[miss-islington]

New changeset 6a56790 by Miss Islington (bot) in branch '3.7':
bpo-33391: Fix refleak in set_symmetric_difference (GH-6670)
6a56790

[miss-islington]

New changeset d554699 by Miss Islington (bot) in branch '3.6':
bpo-33391: Fix refleak in set_symmetric_difference (GH-6670)
d554699

[miss-islington]

New changeset 6d3d02c by Miss Islington (bot) in branch '2.7':
bpo-33391: Fix refleak in set_symmetric_difference (GH-6670)
6d3d02c

[rhettinger]

I had assigned this to myself to review and apply. I would have appreciated you letting me complete that task when I had a chance to take a breath. This was a bug that I caused, so I should be the one responsible for fixing it.

[methane]

I'm sorry. I just reviewed some easy pull requests when I have time.
I'll skip pull requests you assigned yourself next time.