cgi.parse_multipart does not have an associated "errors" parameter with its "encoding" parameter

[hawkowl]

BPO	33497
Nosy	@ned-deily, @serhiy-storchaka, @hawkowl
PRs	bpo-33497: Add errors param to cgi.parse_multipart and make an encoding in FieldStorage use the given errors #6804 [3.7] bpo-33497: Add errors param to cgi.parse_multipart and make an encoding in FieldStorage use the given errors (GH-6804) #6837 bpo-33497: Add NEWS and ACKS entries. #6838 [3.7] bpo-33497: Add NEWS and ACKS entries. (GH-6838) #6840

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-05-14.22:22:48.621>
created_at = <Date 2018-05-14.14:30:10.229>
labels = ['3.8', 'type-bug', '3.7']
title = 'cgi.parse_multipart does not have an associated "errors" parameter with its "encoding" parameter'
updated_at = <Date 2018-05-15.11:45:32.537>
user = 'https://github.com/hawkowl'

bugs.python.org fields:

activity = <Date 2018-05-15.11:45:32.537>
actor = 'hawkowl'
assignee = 'none'
closed = True
closed_date = <Date 2018-05-14.22:22:48.621>
closer = 'ned.deily'
components = []
creation = <Date 2018-05-14.14:30:10.229>
creator = 'hawkowl'
dependencies = []
files = []
hgrepos = []
issue_num = 33497
keywords = ['patch']
message_count = 8.0
messages = ['316510', '316593', '316594', '316596', '316598', '316599', '316601', '316640']
nosy_count = 3.0
nosy_names = ['ned.deily', 'serhiy.storchaka', 'hawkowl']
pr_nums = ['6804', '6837', '6838', '6840']
priority = None
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue33497'
versions = ['Python 3.7', 'Python 3.8']

[hawkowl]

Lack of this parameter means that you may get an exception (if the incoming data is an invalid encoding) you can not get around.

This causes Twisted to be unable to provide a compatible API on Python 3.7.

[ned-deily]

New changeset 545c955 by Ned Deily (Amber Brown) in branch 'master':
bpo-33497: Add errors param to cgi.parse_multipart and make an encoding in FieldStorage use the given errors (GH-6804)
545c955

[ned-deily]

New changeset d063b84 by Ned Deily in branch 'master':
bpo-33497: Add NEWS and ACKS entries. (GH-6838)
d063b84

[ned-deily]

New changeset e8f968d by Ned Deily (Miss Islington (bot)) in branch '3.7':
bpo-33497: Add errors param to cgi.parse_multipart and make an encoding in FieldStorage use the given errors (GH-6804) (GH-6837)
e8f968d

[ned-deily]

New changeset 5195039 by Ned Deily (Miss Islington (bot)) in branch '3.7':
bpo-33497: Add NEWS and ACKS entries. (GH-6838) (GH-6840)
5195039

[ned-deily]

Thanks for the report and the PR, @hawkowl! Merged for 3.7.0rc1.

[serhiy-storchaka]

Is 'replace' the good default value? 'strict' is the default value for most encoding/decoding operations. 'surrogateescape' is used if the failure and the loss of information are not desirable (like in filenames decoding). 'backslashreplace' is good if we want to avoid a failure, but want to expose undecodable bytes in human-readable form.

[hawkowl]

This change mirrors the default in FieldStorage (which it calls). If it's not the best option, then it would need to be changed in FieldStorage too.

(personally, I don't like strict because UnicodeDecodeErrors on untrusted user input kind of sucks, but also replace is kind of broken as well.)