asyncio: transports don't support switching between Protocol and BufferedProtocol

[1st1]

BPO	33654
Nosy	@ned-deily, @asvetlov, @1st1, @miss-islington
PRs	bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() #7130 [3.7] bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() (GH-7130) #7164 bpo-33654: Support protocol type switching in SSLTransport.set_protocol() #7194 [3.7] bpo-33654: Support protocol type switching in SSLTransport.set_protocol() (GH-7194) #7198

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/1st1'
closed_at = <Date 2018-05-28.19:14:06.583>
created_at = <Date 2018-05-26.17:08:31.631>
labels = ['3.8', 'type-bug', '3.7', 'expert-asyncio']
title = "asyncio: transports don't support switching between Protocol and BufferedProtocol"
updated_at = <Date 2018-05-29.09:19:15.519>
user = 'https://github.com/1st1'

bugs.python.org fields:

activity = <Date 2018-05-29.09:19:15.519>
actor = 'miss-islington'
assignee = 'yselivanov'
closed = True
closed_date = <Date 2018-05-28.19:14:06.583>
closer = 'yselivanov'
components = ['asyncio']
creation = <Date 2018-05-26.17:08:31.631>
creator = 'yselivanov'
dependencies = []
files = []
hgrepos = []
issue_num = 33654
keywords = ['patch']
message_count = 8.0
messages = ['317743', '317745', '317748', '317750', '317897', '317900', '317990', '317994']
nosy_count = 4.0
nosy_names = ['ned.deily', 'asvetlov', 'yselivanov', 'miss-islington']
pr_nums = ['7130', '7164', '7194', '7198']
priority = 'high'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue33654'
versions = ['Python 3.7', 'Python 3.8']

[1st1]

1. asyncio.BufferedProtocol is a new Python 3.7 *provisional* API.

2. asyncio.Transport.set_protocol() doesn't support switching between Protocol and BufferedProtocol.

3. Because of (2), another *new* Python 3.7 API "loop.start_tls" doesn't support asyncio.BufferedProtocol at all.

The fix is straightforward and *does not* affect any existing APIs in Python 3.6 and lower. Since the patch adjusts the APIs a little bit, it would be great to merge this in 3.7.0.

However, since only the provisional APIs are changed, this can be theoretically merged to 3.7.1 too. It would be nice, though, to get this into 3.7.0. Ned, your thoughts?

[1st1]

Setting "release blocker" to get Ned's attention.

[ned-deily]

LGTM for 3.7

[1st1]

Thanks, Ned!

[1st1]

New changeset dbf1022 by Yury Selivanov in branch 'master':
bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() (GH-7130)
dbf1022

[miss-islington]

New changeset bc3a002 by Miss Islington (bot) in branch '3.7':
bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() (GH-7130)
bc3a002

[asvetlov]

New changeset 2179022 by Andrew Svetlov (Yury Selivanov) in branch 'master':
bpo-33654: Support protocol type switching in SSLTransport.set_protocol() (bpo-7194)
2179022

[miss-islington]

New changeset be5d616 by Miss Islington (bot) in branch '3.7':
bpo-33654: Support protocol type switching in SSLTransport.set_protocol() (GH-7194)
be5d616