Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDLE: Enable theme-specific color configuration for code context #77860

Closed
csabella opened this issue May 29, 2018 · 8 comments
Closed

IDLE: Enable theme-specific color configuration for code context #77860

csabella opened this issue May 29, 2018 · 8 comments
Assignees
Labels
3.7 3.8 expert-IDLE type-bug

Comments

@csabella
Copy link
Contributor

@csabella csabella commented May 29, 2018

BPO 33679
Nosy @terryjreedy, @csabella, @miss-islington
PRs
  • #7199
  • #7334
  • #7335
  • #7500
  • #7501
  • #7502
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
    closed_at = <Date 2018-06-02.03:02:39.210>
    created_at = <Date 2018-05-29.11:13:51.005>
    labels = ['3.8', 'expert-IDLE', 'type-bug', '3.7']
    title = 'IDLE: Enable theme-specific color configuration for code context'
    updated_at = <Date 2018-06-07.23:34:15.998>
    user = 'https://github.com/csabella'

    bugs.python.org fields:

    activity = <Date 2018-06-07.23:34:15.998>
    actor = 'miss-islington'
    assignee = 'terry.reedy'
    closed = True
    closed_date = <Date 2018-06-02.03:02:39.210>
    closer = 'terry.reedy'
    components = ['IDLE']
    creation = <Date 2018-05-29.11:13:51.005>
    creator = 'cheryl.sabella'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 33679
    keywords = ['patch']
    message_count = 8.0
    messages = ['318009', '318480', '318482', '318483', '318978', '318981', '318985', '318988']
    nosy_count = 3.0
    nosy_names = ['terry.reedy', 'cheryl.sabella', 'miss-islington']
    pr_nums = ['7199', '7334', '7335', '7500', '7501', '7502']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue33679'
    versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

    @csabella
    Copy link
    Contributor Author

    @csabella csabella commented May 29, 2018

    Item 9 from bpo-33610:
    Reenable user config of context colors

    • Add context tag to themes in configuration.
    • In codecontext, get theme and context color from configuration.
    • Use the colors when creating the context label.
    • In timer event, update colors if they have changed.
    • Change name of font_timer_event function.
    • Modify tests to include colors.

    @csabella csabella added type-feature 3.7 3.8 labels May 29, 2018
    @terryjreedy
    Copy link
    Member

    @terryjreedy terryjreedy commented Jun 2, 2018

    New changeset de65162 by Terry Jan Reedy (Cheryl Sabella) in branch 'master':
    bpo-33679: IDLE: Re-enable color configuration for code context (GH-7199)
    de65162

    @miss-islington
    Copy link
    Contributor

    @miss-islington miss-islington commented Jun 2, 2018

    New changeset 4e033c5 by Miss Islington (bot) in branch '3.7':
    bpo-33679: IDLE: Re-enable color configuration for code context (GH-7199)
    4e033c5

    @miss-islington
    Copy link
    Contributor

    @miss-islington miss-islington commented Jun 2, 2018

    New changeset dd851d6 by Miss Islington (bot) in branch '3.6':
    bpo-33679: IDLE: Re-enable color configuration for code context (GH-7199)
    dd851d6

    @terryjreedy terryjreedy changed the title IDLE: Configurable color on code context IDLE: Re-enable color configuration for code context Jun 2, 2018
    @terryjreedy terryjreedy added type-bug and removed type-feature labels Jun 2, 2018
    @terryjreedy
    Copy link
    Member

    @terryjreedy terryjreedy commented Jun 7, 2018

    Summary for users: Previously, there was one code context foreground and background font color setting, default or custom, on the extensions tab, that applied to all themes. Now, each theme has it own setting, as with other color settings. For builting themes, the foreground is the same as normal text; the background is a contrasting gray. Context colors for custom themes are set on the Hightlights tab along with others. When one starts IDLE from a console and loads a custom theme without definitions for 'context', one will see a warning message on the console.

    @terryjreedy terryjreedy changed the title IDLE: Re-enable color configuration for code context IDLE: Enable theme-specific color configuration for code context Jun 7, 2018
    @terryjreedy
    Copy link
    Member

    @terryjreedy terryjreedy commented Jun 7, 2018

    New changeset bed523b by Terry Jan Reedy in branch 'master':
    bpo-33642 and bpo-33679: Revise and condense blurbs (GH-7500)
    bed523b

    @miss-islington
    Copy link
    Contributor

    @miss-islington miss-islington commented Jun 7, 2018

    New changeset ab5da50 by Miss Islington (bot) in branch '3.7':
    bpo-33642 and bpo-33679: Revise and condense blurbs (GH-7500)
    ab5da50

    @miss-islington
    Copy link
    Contributor

    @miss-islington miss-islington commented Jun 7, 2018

    New changeset d071ab1 by Miss Islington (bot) in branch '3.6':
    bpo-33642 and bpo-33679: Revise and condense blurbs (GH-7500)
    d071ab1

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 3.8 expert-IDLE type-bug
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants