-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IDLE: Use text widget for code context instead of label widget #77944
Comments
Item 11 from bpo-33610.
|
This makes detecting the context line a user clicks on slightly easier. See new issue bpo-33768 for discussion. I am not sure now I would do this just for this reason, without trying with the label first. Using a text also allows us to experiment with tagging the context keyword somehow, to see if it seems like an improvement. Perhaps make it bold, or underlined, or the normal keyword color, or some variant thereof (grayed?). So I am inclined to go ahead. I did notice that most of the patch is straightforward substitution. To me, this suggests that the code is pretty good. Also, I think change 'label' (implentation) to 'context' (purpose) is a good change by itself. I would keep this even if we reverted to using Label. |
To your point, when I was adding the colors to configuration for context, I wondered if having context as a text widget could somehow use the colorizer. I didn't really look into it, but it did seem like it might make sense to keep all the foreground text colors the same as they are in the editor. |
I believe the colorizer would need some new code, maybe in a subclass, but it should be possible. I would not know if I liked it until we tried it ;-). |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: