Improper use of SystemError in the mmap module

[ZackerySpytz]

BPO	33767
Nosy	@serhiy-storchaka, @ZackerySpytz, @miss-islington
PRs	bpo-33767: Fix improper use of SystemError by mmap.mmap objects #7381 [3.7] bpo-33767: Fix improper use of SystemError by mmap.mmap objects (GH-7381) #7426 [3.6] bpo-33767: Fix improper use of SystemError by mmap.mmap objects (GH-7381) #7427 [2.7] bpo-33767: Fix improper use of SystemError by mmap.mmap objects (GH-7381) #7432

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-06-05.16:52:00.512>
created_at = <Date 2018-06-04.04:40:18.427>
labels = ['extension-modules', '3.8', 'type-bug', '3.7']
title = 'Improper use of SystemError in the mmap module'
updated_at = <Date 2018-06-05.16:52:00.512>
user = 'https://github.com/ZackerySpytz'

bugs.python.org fields:

activity = <Date 2018-06-05.16:52:00.512>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2018-06-05.16:52:00.512>
closer = 'serhiy.storchaka'
components = ['Extension Modules']
creation = <Date 2018-06-04.04:40:18.427>
creator = 'ZackerySpytz'
dependencies = []
files = []
hgrepos = []
issue_num = 33767
keywords = ['patch']
message_count = 7.0
messages = ['318623', '318630', '318635', '318749', '318753', '318754', '318767']
nosy_count = 3.0
nosy_names = ['serhiy.storchaka', 'ZackerySpytz', 'miss-islington']
pr_nums = ['7381', '7426', '7427', '7432']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue33767'
versions = ['Python 2.7', 'Python 3.6', 'Python 3.7', 'Python 3.8']

[ZackerySpytz]

Both mmap_concat() and mmap_repeat() raise a SystemError when invoked.

[serhiy-storchaka]

Thank you for your PR Zackery!

I concur that an alternative would be to remove mmap_concat() and mmap_repeat(). Why not use this simpler way? Are there any drawbacks?

[ZackerySpytz]

It doesn't look like it. I've updated the PR.

[serhiy-storchaka]

New changeset e9e3976 by Serhiy Storchaka (Zackery Spytz) in branch 'master':
bpo-33767: Fix improper use of SystemError by mmap.mmap objects (GH-7381)
e9e3976

[miss-islington]

New changeset 631fe1f by Miss Islington (bot) in branch '3.7':
bpo-33767: Fix improper use of SystemError by mmap.mmap objects (GH-7381)
631fe1f

[miss-islington]

New changeset ae55d29 by Miss Islington (bot) in branch '3.6':
bpo-33767: Fix improper use of SystemError by mmap.mmap objects (GH-7381)
ae55d29

[serhiy-storchaka]

New changeset 3014d6e by Serhiy Storchaka in branch '2.7':
[2.7] bpo-33767: Fix improper use of SystemError by mmap.mmap objects (GH-7381) (GH-7432)
3014d6e