Several AttributeError in zipfile seek() methods

[espdev]

BPO	34035
Nosy	@vstinner, @serhiy-storchaka, @miss-islington, @remilapeyre, @BoboTiG, @espdev
PRs	bpo-34035: Fix several AttributeError in zipfile seek() methods #8527 [3.7] bpo-34035: Fix several AttributeError in zipfile seek() methods. (GH-8527) #8556

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-07-29.20:07:37.822>
created_at = <Date 2018-07-03.18:24:34.712>
labels = ['3.7', '3.8', 'type-bug', 'library', 'easy']
title = 'Several AttributeError in zipfile seek() methods'
updated_at = <Date 2018-10-17.14:10:33.534>
user = 'https://github.com/espdev'

bugs.python.org fields:

activity = <Date 2018-10-17.14:10:33.534>
actor = 'Dariush Azimi'
assignee = 'none'
closed = True
closed_date = <Date 2018-07-29.20:07:37.822>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2018-07-03.18:24:34.712>
creator = 'espdev'
dependencies = []
files = []
hgrepos = []
issue_num = 34035
keywords = ['patch', 'easy']
message_count = 10.0
messages = ['320996', '320999', '321038', '321042', '322540', '322639', '322642', '322643', '322785', '327899']
nosy_count = 7.0
nosy_names = ['vstinner', 'serhiy.storchaka', 'miss-islington', 'remi.lapeyre', 'Tiger-222', 'espdev', 'Dariush Azimi']
pr_nums = ['8527', '8556']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue34035'
versions = ['Python 3.7', 'Python 3.8']

[espdev]

The misprint in the file lib/zipfile.py in the line 704 leads to AttributeError: '_SharedFile' object has no attribute 'writing'

"self.writing()" should be replaced by "self._writing()". I also think this code shold be covered by tests.

[espdev]

I think the line 1031 also contains the misprint and will raise NameError.

self._decompressor = zipfile._get_decompressor(self._compress_type)

"zipfile." is not correct code in this place.

[remilapeyre]

Hi Evegeny, I was able to reproduce the issue, if it's all right for you I would like to post a PR to solve the issue and extend the test suite od this module.

[espdev]

Hi Rémi, it would be great if you posted a PR.

[BoboTiG]

Little word to say I am working on at EuroPython 2018.

[serhiy-storchaka]

New changeset 3f8c691 by Serhiy Storchaka (Mickaël Schoentgen) in branch 'master':
bpo-34035: Fix several AttributeError in zipfile seek() methods. (GH-8527)
3f8c691

[miss-islington]

New changeset ad4f64d by Miss Islington (bot) in branch '3.7':
bpo-34035: Fix several AttributeError in zipfile seek() methods. (GH-8527)
ad4f64d

[serhiy-storchaka]

Thank you for your report Evgeny and for your PR Mickaël!

[vstinner]

Note: the seek() method has been added by bpo-22908 (commit 066df4f), and Python 3.6 is not affected.

[DariushAzimi]

Had the same issue with python 3.7 and went back to python 3.6. There are no issues with python 3.6.4