Lib/trace.cover not removed by the clean target

[doko42]

BPO	34171
Nosy	@doko42, @berkerpeksag, @zware, @serhiy-storchaka, @ZackerySpytz, @pablogsal, @miss-islington
PRs	bpo-34171: Remove cover files from Lib/ #8666 bpo-34171: Prevent creating Lib/trace.cover when run the trace module. #8841 [3.7] bpo-34171: Prevent creating Lib/trace.cover when run the trace module. (GH-8841) #8919 bpo-34171: Fix test_trace. #8940 [3.7] bpo-34171: Fix test_trace. (GH-8940) #8951

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-12-15.14:03:24.391>
created_at = <Date 2018-07-20.16:08:57.601>
labels = ['3.8', 'build', '3.7']
title = 'Lib/trace.cover not removed by the clean target'
updated_at = <Date 2018-12-15.14:03:24.390>
user = 'https://github.com/doko42'

bugs.python.org fields:

activity = <Date 2018-12-15.14:03:24.390>
actor = 'cheryl.sabella'
assignee = 'none'
closed = True
closed_date = <Date 2018-12-15.14:03:24.391>
closer = 'cheryl.sabella'
components = ['Build']
creation = <Date 2018-07-20.16:08:57.601>
creator = 'doko'
dependencies = []
files = []
hgrepos = []
issue_num = 34171
keywords = ['patch']
message_count = 15.0
messages = ['322026', '323057', '323812', '324045', '324049', '324062', '324064', '324065', '324074', '324112', '324120', '324121', '324126', '324163', '324223']
nosy_count = 7.0
nosy_names = ['doko', 'berker.peksag', 'zach.ware', 'serhiy.storchaka', 'ZackerySpytz', 'pablogsal', 'miss-islington']
pr_nums = ['8666', '8841', '8919', '8940', '8951']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue34171'
versions = ['Python 3.7', 'Python 3.8']

[doko42]

Lib/trace.cover is not removed by the clean target, and apparently this file is always created in the source tree, not in the build tree. It should be created in the build tree, if that's not possible, it should be cleaned in any case.

[ZackerySpytz]

It seems that this file is left by test_trace after commit 47ab154.

[serhiy-storchaka]

PR 8841 prevents creating Lib/trace.cover when run the trace module.

[serhiy-storchaka]

New changeset c406d5c by Serhiy Storchaka in branch 'master':
bpo-34171: Prevent creating Lib/trace.cover when run the trace module. (GH-8841)
c406d5c

[miss-islington]

New changeset 80e9fed by Miss Islington (bot) in branch '3.7':
bpo-34171: Prevent creating Lib/trace.cover when run the trace module. (GH-8841)
80e9fed

[pablogsal]

Several buildbots are failing due to commit c406d5c:

https://buildbot.python.org/all/#/builders/40/builds/709
https://buildbot.python.org/all/#/builders/21/builds/1459
https://buildbot.python.org/all/#/builders/13/builds/1476
https://buildbot.python.org/all/#/builders/53/builds/1470
https://buildbot.python.org/all/#/builders/133/builds/477
https://buildbot.python.org/all/#/builders/145/builds/327
https://buildbot.python.org/all/#/builders/85/builds/1302
https://buildbot.python.org/all/#/builders/141/builds/358
https://buildbot.python.org/all/#/builders/126/builds/564
https://buildbot.python.org/all/#/builders/147/builds/213
https://buildbot.python.org/all/#/builders/119/builds/611
https://buildbot.python.org/all/#/builders/116/builds/590
https://buildbot.python.org/all/#/builders/143/builds/233
https://buildbot.python.org/all/#/builders/93/builds/1072
https://buildbot.python.org/all/#/builders/3/builds/1257
https://buildbot.python.org/all/#/builders/32/builds/1331
https://buildbot.python.org/all/#/builders/115/builds/520
https://buildbot.python.org/all/#/builders/128/builds/571
https://buildbot.python.org/all/#/builders/99/builds/1335
https://buildbot.python.org/all/#/builders/121/builds/497
https://buildbot.python.org/all/#/builders/113/builds/540
https://buildbot.python.org/all/#/builders/154/builds/166

Sample error:

======================================================================
FAIL: test_cover_files_written_no_highlight (test.test_trace.TestCoverageCommandLineOutput)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_trace.py", line 393, in test_cover_files_written_no_highlight
    self.assertFalse(os.path.exists(tracecoverpath))
AssertionError: True is not false

---

Ran 21 tests in 17.796s
FAILED (failures=1)
test test_trace failed
1 test failed again:
test_trace

[serhiy-storchaka]

Seems this is a temporary issue. Tests are failed due to trace.cover files left from previous runs. Recreating the working space from zero should fix the issue, but I don't know how to do this on all buildbots.

[pablogsal]

@zach.ware Is there a way to clean the workspace of these buildbots programmatically/from the UI? I can do it myself if you tell me how it must be done.

[zware]

No, there isn't. However, python/buildmaster-config#43 should help; I'll try to get that deployed later today.

[zware]

It looks like python/buildmaster-config#43 won't actually help; I changed it to use method='clean' because we don't want to blow away the externals directory on Windows buildbots, and *.cover is in .gitignore so [Lib/trace.cover](https://github.com/python/cpython/blob/main/Lib/trace.cover) will not be removed.

[pablogsal]

Can we manually ssh into the buildbots from the buildbot master and delete the file?

[serhiy-storchaka]

It may be easier to remove "trace.cover" before testing every time than clean up all buildbots once.

[zware]

Can we manually ssh into the buildbots from the buildbot master and delete the file?

No, there is no access to the workers except for the connection created by each worker for the purpose of buildbot communication (and individually by each worker owner).

It may be easier to remove "trace.cover" before testing every time than clean up all buildbots once.

I agree. Alternately, the test could be changed to avoid that assertion; it's strange that the test could fail just because a file could happen to exist outside of the test's control.

[serhiy-storchaka]

New changeset b44a1d4 by Serhiy Storchaka in branch 'master':
bpo-34171: Fix test_trace. (GH-8940)
b44a1d4

[serhiy-storchaka]

New changeset e3f2082 by Serhiy Storchaka (Miss Islington (bot)) in branch '3.7':
bpo-34171: Fix test_trace. (GH-8940) (GH-8951)
e3f2082