-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
IDLE: Make TextView use the configured theme colors #78729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I am about to review and test, including live testing on Windows, with an eye to merging before the Monday midnight deadline for the coming releases. At the moment I have no personal preference, nor insight into likely user perferences. Tal, what is your rationale for the proposal? Personal preference? Do you think a majority of user will prefer this? Have you hand-tested (or htested) on both Mac and Linux? Cheryl, what do you think? |
I did a review on the PR which probably answers your question, but I'll summarize here. I think consistency in the windows would be good. Consistency would include (but not limited to) foreground and background color, font style, font size, and behavior such as resizing. If a user has changed to a dark theme with a font size of 20, then opening up the help or find windows should use that. So, I think this is a good suggestion, but I think it should be considered within a larger scope. |
Investigating the code, I discovered that |
After live testing, I like 'after' at least as well as 'before'. I also decided that people who selects a dark theme because black on white is obnoxious to their eyes should have their choice on all text panes. |
The first follow-up, bpo-34774, makes the help viewer use the current theme. It would be good if it were separately tested on Linux/Mac, as it uses multiple tags. |
Thanks for the review, discussion and approval, Cheryl and Terry! |
I removed 2.7 because I stopped routinely backporting to 2.7 some time ago because a) renaming files (which could not be backported) and using ttk widgets (ditto) made it much harder, and b) it was empirically too easy to introduce regressions without *thorough* hand testing. Given that most beginners now start with 3.x, I prefer merging more patches for current 3.x. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: