You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
assignee='https://github.com/taleinat'closed_at=<Date2018-09-23.13:33:30.026>created_at=<Date2018-08-30.12:39:32.463>labels= ['3.8', 'expert-IDLE', 'type-feature', '3.7']
title='IDLE: Make TextView use the configured theme colors'updated_at=<Date2018-09-23.16:38:19.781>user='https://github.com/taleinat'
I am about to review and test, including live testing on Windows, with an eye to merging before the Monday midnight deadline for the coming releases. At the moment I have no personal preference, nor insight into likely user perferences.
Tal, what is your rationale for the proposal? Personal preference? Do you think a majority of user will prefer this? Have you hand-tested (or htested) on both Mac and Linux?
I did a review on the PR which probably answers your question, but I'll summarize here.
I think consistency in the windows would be good. Consistency would include (but not limited to) foreground and background color, font style, font size, and behavior such as resizing. If a user has changed to a dark theme with a font size of 20, then opening up the help or find windows should use that.
So, I think this is a good suggestion, but I think it should be considered within a larger scope.
Investigating the code, I discovered that
# TODO: get fg/bg from theme."
is my rewrite on 2016 8 31, a3623c8, of
#elguavas - config placeholders til config stuff completed
Stephen Gava either wrote or modified the file in 2001. Using the config settings was the original intention, and I thought two years ago and in subsequent revisions that we should at least try it.
After live testing, I like 'after' at least as well as 'before'. I also decided that people who selects a dark theme because black on white is obnoxious to their eyes should have their choice on all text panes.
I removed 2.7 because I stopped routinely backporting to 2.7 some time ago because a) renaming files (which could not be backported) and using ttk widgets (ditto) made it much harder, and b) it was empirically too easy to introduce regressions without *thorough* hand testing. Given that most beginners now start with 3.x, I prefer merging more patches for current 3.x.