Signature.from_callable sometimes drops subclassing

[bukzor]

BPO	34706
Nosy	@gpshead, @bukzor, @matrixise, @iritkatriel
PRs	bpo-34706: Preserve subclassing in Signature.from_callable  #9344 bpo-34706: Preserve subclassing in inspect.Signature.from_callable #16108 [3.8] bpo-34706: Preserve subclassing in inspect.Signature.from_callable (GH-16108) #16113 [3.7] bpo-34706: Preserve subclassing in inspect.Signature.from_callable (GH-16108) #16114

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/gpshead'
closed_at = <Date 2020-10-10.01:37:03.831>
created_at = <Date 2018-09-16.21:12:01.624>
labels = ['3.7', '3.8', 'type-bug', 'library', '3.9']
title = 'Signature.from_callable sometimes drops subclassing'
updated_at = <Date 2020-10-10.01:37:03.830>
user = 'https://github.com/bukzor'

bugs.python.org fields:

activity = <Date 2020-10-10.01:37:03.830>
actor = 'gregory.p.smith'
assignee = 'gregory.p.smith'
closed = True
closed_date = <Date 2020-10-10.01:37:03.831>
closer = 'gregory.p.smith'
components = ['Library (Lib)']
creation = <Date 2018-09-16.21:12:01.624>
creator = 'bukzor'
dependencies = []
files = []
hgrepos = []
issue_num = 34706
keywords = ['patch']
message_count = 5.0
messages = ['325501', '352357', '352382', '352383', '378354']
nosy_count = 4.0
nosy_names = ['gregory.p.smith', 'bukzor', 'matrixise', 'iritkatriel']
pr_nums = ['9344', '16108', '16113', '16114']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue34706'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']

[bukzor]

Specifically in the case of a class that does not override its constructor signature inherited from object.

Github PR incoming shortly.

[gpshead]

New changeset 5b9ff7a by Gregory P. Smith in branch 'master':
bpo-34706: Preserve subclassing in inspect.Signature.from_callable (GH-16108)
5b9ff7a

[matrixise]

New changeset cf25765 by Stéphane Wirtel (Miss Islington (bot)) in branch '3.8':
bpo-34706: Preserve subclassing in inspect.Signature.from_callable (GH-16108) (GH-16113)
cf25765

[matrixise]

New changeset 3906920 by Stéphane Wirtel (Miss Islington (bot)) in branch '3.7':
bpo-34706: Preserve subclassing in inspect.Signature.from_callable (GH-16108) (GH-16114)
3906920

[iritkatriel]

This seems complete, can it be closed?