Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature.from_callable sometimes drops subclassing #78887

Closed
bukzor mannequin opened this issue Sep 16, 2018 · 5 comments
Closed

Signature.from_callable sometimes drops subclassing #78887

bukzor mannequin opened this issue Sep 16, 2018 · 5 comments
Assignees
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@bukzor
Copy link
Mannequin

bukzor mannequin commented Sep 16, 2018

BPO 34706
Nosy @gpshead, @bukzor, @matrixise, @iritkatriel
PRs
  • bpo-34706: Preserve subclassing in Signature.from_callable  #9344
  • bpo-34706: Preserve subclassing in inspect.Signature.from_callable #16108
  • [3.8] bpo-34706: Preserve subclassing in inspect.Signature.from_callable (GH-16108) #16113
  • [3.7] bpo-34706: Preserve subclassing in inspect.Signature.from_callable (GH-16108) #16114
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/gpshead'
    closed_at = <Date 2020-10-10.01:37:03.831>
    created_at = <Date 2018-09-16.21:12:01.624>
    labels = ['3.7', '3.8', 'type-bug', 'library', '3.9']
    title = 'Signature.from_callable sometimes drops subclassing'
    updated_at = <Date 2020-10-10.01:37:03.830>
    user = 'https://github.com/bukzor'

    bugs.python.org fields:

    activity = <Date 2020-10-10.01:37:03.830>
    actor = 'gregory.p.smith'
    assignee = 'gregory.p.smith'
    closed = True
    closed_date = <Date 2020-10-10.01:37:03.831>
    closer = 'gregory.p.smith'
    components = ['Library (Lib)']
    creation = <Date 2018-09-16.21:12:01.624>
    creator = 'bukzor'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 34706
    keywords = ['patch']
    message_count = 5.0
    messages = ['325501', '352357', '352382', '352383', '378354']
    nosy_count = 4.0
    nosy_names = ['gregory.p.smith', 'bukzor', 'matrixise', 'iritkatriel']
    pr_nums = ['9344', '16108', '16113', '16114']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue34706'
    versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']

    @bukzor
    Copy link
    Mannequin Author

    bukzor mannequin commented Sep 16, 2018

    Specifically in the case of a class that does not override its constructor signature inherited from object.

    Github PR incoming shortly.

    @bukzor bukzor mannequin added 3.7 (EOL) end of life stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Sep 16, 2018
    @gpshead gpshead added 3.8 only security fixes 3.9 only security fixes labels Sep 13, 2019
    @gpshead gpshead self-assigned this Sep 13, 2019
    @gpshead
    Copy link
    Member

    gpshead commented Sep 13, 2019

    New changeset 5b9ff7a by Gregory P. Smith in branch 'master':
    bpo-34706: Preserve subclassing in inspect.Signature.from_callable (GH-16108)
    5b9ff7a

    @matrixise
    Copy link
    Member

    New changeset cf25765 by Stéphane Wirtel (Miss Islington (bot)) in branch '3.8':
    bpo-34706: Preserve subclassing in inspect.Signature.from_callable (GH-16108) (GH-16113)
    cf25765

    @matrixise
    Copy link
    Member

    New changeset 3906920 by Stéphane Wirtel (Miss Islington (bot)) in branch '3.7':
    bpo-34706: Preserve subclassing in inspect.Signature.from_callable (GH-16108) (GH-16114)
    3906920

    @iritkatriel
    Copy link
    Member

    This seems complete, can it be closed?

    @gpshead gpshead closed this as completed Oct 10, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants