SSL Module build fails with more pedantic compiler flags

[commodo]

BPO	34710
Nosy	@tiran, @commodo, @miss-islington
PRs	bpo-34710: fix SSL module build #9347 [3.7] bpo-34710: fix SSL module build (GH-9347) #9351 [3.6] bpo-34710: fix SSL module build (GH-9347) #9352 [2.7] bpo-34710: fix SSL module build (GH-9347) #9353

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/tiran'
closed_at = <Date 2018-09-17.14:30:13.561>
created_at = <Date 2018-09-17.10:06:35.376>
labels = ['expert-SSL', 'build', '3.7']
title = 'SSL Module build fails with more pedantic compiler flags'
updated_at = <Date 2018-09-17.14:30:27.594>
user = 'https://github.com/commodo'

bugs.python.org fields:

activity = <Date 2018-09-17.14:30:27.594>
actor = 'christian.heimes'
assignee = 'christian.heimes'
closed = True
closed_date = <Date 2018-09-17.14:30:13.561>
closer = 'christian.heimes'
components = ['Build', 'SSL']
creation = <Date 2018-09-17.10:06:35.376>
creator = 'Alexandru Ardelean'
dependencies = []
files = []
hgrepos = []
issue_num = 34710
keywords = ['patch']
message_count = 6.0
messages = ['325518', '325525', '325534', '325535', '325544', '325547']
nosy_count = 3.0
nosy_names = ['christian.heimes', 'Alexandru Ardelean', 'miss-islington']
pr_nums = ['9347', '9351', '9352', '9353']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue34710'
versions = ['Python 3.7']

[commodo]

See: openwrt/packages#7051
The issue seems a bit older ; see comment:
#3943 (comment)

Build error happens on OpenWrt as well:

---------------------------------------------------------------
<openwrt>/build_dir/target-i386_pentium4_musl/Python-3.7.0/Modules/_ssl.c:4000:5: error: implicit declaration of function 'DH_free'; did you mean 'lh_free'? [-Werror=implicit-function-declaration]
DH_free(dh);
^~~~~~~
lh_free
cc1: some warnings being treated as errors

Python build finished successfully!
The necessary bits to build these optional modules were not found:
_tkinter _uuid nis
To find the necessary bits, look in setup.py in detect_modules() for the module's name.

The following modules found by detect_modules() in setup.py, have been
built by the Makefile instead, as configured by the Setup files:
_abc atexit pwd
time zlib

Failed to build these modules:
_ssl

Makefile:618: recipe for target 'sharedmods' failed

---------------------------------------------------------------

The fix seems to be to include <openssl/dh.h>.

[tiran]

New changeset b3a271f by Christian Heimes (Alexandru Ardelean) in branch 'master':
bpo-34710: fix SSL module build (GH-9347)
b3a271f

[miss-islington]

New changeset e2c0aea by Miss Islington (bot) in branch '3.7':
bpo-34710: fix SSL module build (GH-9347)
e2c0aea

[miss-islington]

New changeset fff869e by Miss Islington (bot) in branch '3.6':
bpo-34710: fix SSL module build (GH-9347)
fff869e

[miss-islington]

New changeset 5f883fc by Miss Islington (bot) (Christian Heimes) in branch '2.7':
[2.7] bpo-34710: fix SSL module build (GH-9347) (GH-9353)
5f883fc

[tiran]

Thanks!