Update install-sh #78946
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
assignee = None closed_at = <Date 2018-10-29.20:43:37.885> created_at = <Date 2018-09-21.15:47:07.535> labels = ['build', '3.8'] title = 'Update install-sh' updated_at = <Date 2018-10-30.06:00:07.576> user = 'https://github.com/stratakis'
activity = <Date 2018-10-30.06:00:07.576> actor = 'Michael.Felt' assignee = 'none' closed = True closed_date = <Date 2018-10-29.20:43:37.885> closer = 'vstinner' components = ['Build'] creation = <Date 2018-09-21.15:47:07.535> creator = 'cstratak' dependencies =  files =  hgrepos =  issue_num = 34765 keywords = ['patch'] message_count = 12.0 messages = ['325996', '325998', '327947', '327948', '328444', '328445', '328447', '328853', '328862', '328867', '328868', '328883'] nosy_count = 4.0 nosy_names = ['vstinner', 'zach.ware', 'Michael.Felt', 'cstratak'] pr_nums = ['9592', '10225'] priority = 'normal' resolution = 'fixed' stage = 'resolved' status = 'closed' superseder = None type = None url = 'https://bugs.python.org/issue34765' versions = ['Python 3.8']
The text was updated successfully, but these errors were encountered:
The install-sh file that python uses for autotools is horribly outdated. Last update was 16 years ago and it's being copied from automake's source code.
Updating it to modern standards could potentially fix issues for systems that use autotools, but it has the downside of having some backwards incompatible changes e.g.  (or you can search at their NEWS file ) which could break some previous applied workarounds.
As things stand, there is no bug at the moment and autotools just work so would a PR for updating install-sh to a newer version be considered?
Adding to this, the reason I initially caught up with that, was due to a coverity scan.
Error: SHELLCHECK_WARNING: [#def1]
Error: SHELLCHECK_WARNING: [#def2]
So the transform_arg is unused, but I'm not well versed with autotools so I don't know the implications of that.
This is closed, however, since this was merged the AIX buildbots have failed. This is because the file mode bits lack the -x
root@x066:[/data/prj/python/git/cpython-master]find . -name install-sh -ls
Can this be fixed as part of this issue, or do I need to open a new one?
Currently both AIX build-bots fail in the build phase with:
renaming build/scripts-3.8/pydoc3 to build/scripts-3.8/pydoc3.8
FYI: On my manual build server I have coreutils "install" installed, and it seems install-sh is not called in that case (which is why I never saw with manual builds)
FYI: There is also an issue (I hope side-effect) that pyexpat is not building while install-sh is not executing.
I see the new PR - thx for the quick response!