Allow querying a Path's mime-type

[YoSTEALTH]

BPO	34926
Nosy	@rhettinger, @pitrou, @YoSTEALTH, @tirkarthi
PRs	bpo-34926: Make mimetypes.guess_type accept os.PathLike objects #9777

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/pitrou'
closed_at = <Date 2018-10-12.06:49:13.957>
created_at = <Date 2018-10-08.06:07:23.973>
labels = ['easy', '3.8', 'type-feature', 'library']
title = "Allow querying a Path's mime-type"
updated_at = <Date 2018-10-12.07:00:45.579>
user = 'https://github.com/YoSTEALTH'

bugs.python.org fields:

activity = <Date 2018-10-12.07:00:45.579>
actor = 'pitrou'
assignee = 'pitrou'
closed = True
closed_date = <Date 2018-10-12.06:49:13.957>
closer = 'xtreak'
components = ['Library (Lib)']
creation = <Date 2018-10-08.06:07:23.973>
creator = 'YoSTEALTH'
dependencies = []
files = []
hgrepos = []
issue_num = 34926
keywords = ['patch', 'easy']
message_count = 7.0
messages = ['327323', '327377', '327382', '327383', '327478', '327565', '327566']
nosy_count = 4.0
nosy_names = ['rhettinger', 'pitrou', 'YoSTEALTH', 'xtreak']
pr_nums = ['9777']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue34926'
versions = ['Python 3.8']

[YoSTEALTH]

How about adding basic "mime_type" method to "pathlib.Path" ?

Code would do something like:

    import mimetypes


    def mime_type(name):
        """Mime-type of the file."""
        find = name.rfind('.')
        ext = '' if find == -1 else name[find:]
        return mimetypes.types_map.get(ext, 'application/octet-stream')

Users would use it like so:

    import pathlib

    file = pathlib.Path('hello_world.py')
    print(file.mime_type)  # 'text/x-python'

[rhettinger]

-0 There is some value in having a separation of responsibilities and in not adding another dependency. On the other hand, I can see how this would sometimes be convenient.

Assigning to Antoine to make the decision.

[tirkarthi]

Thanks for the report. There was a similar request to add pathlib.rmtree (bpo-33498) and adding more methods as Raymond mentioned might be convenient but there is a maintenance cost (msg316517) since there is a consensus that pathlib should do everything os.path does. It's up to Antoine to decide on this.

[pitrou]

I would rather have the mimetypes module improved to accept Path-like objects, so that the following works:

>>> p = Path('LICENSE.txt')
>>> mimetypes.guess_type(p)
('text/plain', None)

It should be quite simple to implement as well.

[pitrou]

New changeset 7e18dee by Antoine Pitrou (Mayank Asthana) in branch 'master':
bpo-34926: Make mimetypes.guess_type accept os.PathLike objects (GH-9777)
7e18dee

[tirkarthi]

As part of triaging, I am closing this since this was merged with doc changes and there was no back port done since it's an enhancement. Antoine, feel free to reopen this if there are any changes left.

Thanks everybody for the feedback and review.

[pitrou]

No, I simply forgot to close it. Thank you!