Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_functools dead code after FIXME #79433

lysnikolaou opened this issue Nov 15, 2018 · 4 comments

test_functools dead code after FIXME #79433

lysnikolaou opened this issue Nov 15, 2018 · 4 comments
3.8 only security fixes tests Tests in the Lib/test dir


Copy link

BPO 35252
Nosy @ambv, @csabella, @lysnikolaou
  • bpo-35252: Remove FIXME from test_functools #10551
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2019-05-19.23:54:37.699>
    created_at = <Date 2018-11-15.01:14:22.853>
    labels = ['3.8', 'tests']
    title = 'test_functools dead code after FIXME'
    updated_at = <Date 2019-05-19.23:54:37.699>
    user = '' fields:

    activity = <Date 2019-05-19.23:54:37.699>
    actor = 'lys.nikolaou'
    assignee = 'none'
    closed = True
    closed_date = <Date 2019-05-19.23:54:37.699>
    closer = 'lys.nikolaou'
    components = ['Tests']
    creation = <Date 2018-11-15.01:14:22.853>
    creator = 'lys.nikolaou'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 35252
    keywords = ['patch']
    message_count = 4.0
    messages = ['329937', '329940', '342707', '342875']
    nosy_count = 3.0
    nosy_names = ['lukasz.langa', 'cheryl.sabella', 'lys.nikolaou']
    pr_nums = ['10551']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = ''
    versions = ['Python 3.8']

    Copy link
    Contributor Author

    In test_functools.TestSingleDispatch.test_invalid_registrations (

    # FIXME: The following will only work after PEP 560 is implemented.
    ) there is a FIXME with an immediate return afterwards that says that the code after the return should only be allowed to run after PEP-560 is implemented. Now that it is implemented the dead code should work fine, so the return has to be deleted.

    @lysnikolaou lysnikolaou added 3.8 only security fixes tests Tests in the Lib/test dir labels Nov 15, 2018
    Copy link
    Contributor Author

    It actually seems like the test after the FIXME is wrong and should be changed or deleted altogether. Can someone give a pointer or two on what would be the best choice here?

    Copy link

    @lukasz.langa added this FIXME comment originally, so nosying him for a review.

    Copy link

    ambv commented May 19, 2019

    New changeset d673810 by Łukasz Langa (Lysandros Nikolaou) in branch 'master':
    bpo-35252: Remove FIXME from test_functools (GH-10551)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    3.8 only security fixes tests Tests in the Lib/test dir
    None yet

    No branches or pull requests

    3 participants