test_functools dead code after FIXME

[lysnikolaou]

BPO	35252
Nosy	@ambv, @csabella, @lysnikolaou
PRs	bpo-35252: Remove FIXME from test_functools #10551

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-05-19.23:54:37.699>
created_at = <Date 2018-11-15.01:14:22.853>
labels = ['3.8', 'tests']
title = 'test_functools dead code after FIXME'
updated_at = <Date 2019-05-19.23:54:37.699>
user = 'https://github.com/lysnikolaou'

bugs.python.org fields:

activity = <Date 2019-05-19.23:54:37.699>
actor = 'lys.nikolaou'
assignee = 'none'
closed = True
closed_date = <Date 2019-05-19.23:54:37.699>
closer = 'lys.nikolaou'
components = ['Tests']
creation = <Date 2018-11-15.01:14:22.853>
creator = 'lys.nikolaou'
dependencies = []
files = []
hgrepos = []
issue_num = 35252
keywords = ['patch']
message_count = 4.0
messages = ['329937', '329940', '342707', '342875']
nosy_count = 3.0
nosy_names = ['lukasz.langa', 'cheryl.sabella', 'lys.nikolaou']
pr_nums = ['10551']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue35252'
versions = ['Python 3.8']

[lysnikolaou]

In test_functools.TestSingleDispatch.test_invalid_registrations (

cpython/Lib/test/test_functools.py

Line 2299 in 4c596d5

# FIXME: The following will only work after PEP 560 is implemented.

) there is a FIXME with an immediate return afterwards that says that the code after the return should only be allowed to run after PEP-560 is implemented. Now that it is implemented the dead code should work fine, so the return has to be deleted.

[lysnikolaou]

It actually seems like the test after the FIXME is wrong and should be changed or deleted altogether. Can someone give a pointer or two on what would be the best choice here?

[csabella]

@lukasz.langa added this FIXME comment originally, so nosying him for a review.

[ambv]

New changeset d673810 by Łukasz Langa (Lysandros Nikolaou) in branch 'master':
bpo-35252: Remove FIXME from test_functools (GH-10551)
d673810