Do not ignore errors when create posix.environ

[serhiy-storchaka]

BPO	35445
Nosy	@larryhastings, @serhiy-storchaka
PRs	bpo-35445: Do not ignore memory errors when create posix.environ. #11049

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-12-10.10:19:28.431>
created_at = <Date 2018-12-09.12:34:29.663>
labels = ['extension-modules', 'type-feature', '3.8']
title = 'Do not ignore errors when create posix.environ'
updated_at = <Date 2018-12-10.10:19:28.430>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2018-12-10.10:19:28.430>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2018-12-10.10:19:28.431>
closer = 'serhiy.storchaka'
components = ['Extension Modules']
creation = <Date 2018-12-09.12:34:29.663>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 35445
keywords = ['patch']
message_count = 2.0
messages = ['331427', '331483']
nosy_count = 2.0
nosy_names = ['larry', 'serhiy.storchaka']
pr_nums = ['11049']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue35445'
versions = ['Python 3.8']

[serhiy-storchaka]

Currently most errors during creating posix.environ are ignored except an error of creating an empty dict.

The initial revision 85a5fbb contained the comment "XXX This part ignores errors". Later changes removed "XXX" from the comment and added explicit error clearing. Later the POSIX code was duplicated for Windows. It looks to me that that comment was not declared the intentional behavior, but just described existing code, and was left as a reminder for implementing error handling.

The proposed PR implements proper error handling in this code.

[serhiy-storchaka]

New changeset 6fef0f1 by Serhiy Storchaka in branch 'master':
bpo-35445: Do not ignore memory errors when create posix.environ. (GH-11049)
6fef0f1