Test test_imaplib fail in test_imap4_host_default_value

[PetrStupka]

BPO	35505
Nosy	@vstinner, @miss-islington
PRs	bpo-35505: Skip test_imap4_host_default_value if localhost listens on IMAP port #11823 [3.7] bpo-35505: Skip test_imap4_host_default_value if localhost listens on IMAP port (GH-11823) #11829

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-02-12.20:57:12.279>
created_at = <Date 2018-12-15.00:20:22.706>
labels = ['3.7', 'type-bug', 'tests']
title = 'Test test_imaplib fail in test_imap4_host_default_value'
updated_at = <Date 2019-02-12.20:57:12.278>
user = 'https://bugs.python.org/PetrStupka'

bugs.python.org fields:

activity = <Date 2019-02-12.20:57:12.278>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2019-02-12.20:57:12.279>
closer = 'vstinner'
components = ['Tests']
creation = <Date 2018-12-15.00:20:22.706>
creator = 'Petr Stupka'
dependencies = []
files = []
hgrepos = []
issue_num = 35505
keywords = ['patch']
message_count = 4.0
messages = ['331881', '335342', '335345', '335369']
nosy_count = 3.0
nosy_names = ['vstinner', 'miss-islington', 'Petr Stupka']
pr_nums = ['11823', '11829']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue35505'
versions = ['Python 3.7']

[PetrStupka]

OS: CentOS Linux release 7.6.1810 (Core)

======================================================================
FAIL: test_imap4_host_default_value (test.test_imaplib.TestImaplib)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/home/stupka/build/Python-3.7.1/Lib/test/test_imaplib.py", line 83, in test_imap4_host_default_value
    imaplib.IMAP4()
AssertionError: OSError not raised

Stderr:
/home/stupka/build/Python-3.7.1/Lib/socket.py:660: ResourceWarning: unclosed <socket.socket fd=3, family=AddressFamily.AF_INET6, type=SocketKind.SOCK_STREAM, proto=6, laddr=('::1', 59922, 0, 0),
raddr=('::1', 143, 0, 0)>
self._sock = None

----------------------------------------------------------------------

This test fails when there is (in my case) dovecot running and listening
on ::1, port 143 - expected exception is not raised.
With dovecot stopped and nothing listening on port 143 the test passes.

It should probably check if there is something listening on ::1:143 and if so then the test can be skipped?

[vstinner]

New changeset 3dc67d0 by Victor Stinner (Matěj Cepl) in branch 'master':
bpo-35505: Skip test_imap4_host_default_value if localhost listens on IMAP port (GH-11823)
3dc67d0

[miss-islington]

New changeset 009220e by Miss Islington (bot) in branch '3.7':
bpo-35505: Skip test_imap4_host_default_value if localhost listens on IMAP port (GH-11823)
009220e

[vstinner]

Thanks Matěj Cepl for the fix and thanks Petr Stupka for the bug report ;-)