You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
assignee=Noneclosed_at=<Date2019-01-09.13:13:43.951>created_at=<Date2018-12-21.10:08:03.393>labels= ['3.8', 'build', '3.7']
title='Some define guards for Solaris are wrong'updated_at=<Date2019-03-29.14:23:16.368>user='https://github.com/kulikjak'
Python source code uses on several places ifdef sun or defined(sun) without the underscores, which is not standard compliant and shouldn't be used. Our recent Solaris python build ended up skipping these sections resulting in some obvious problems.
We are building previous versions of Python with Solaris Studio which works with define guards as they are right now. 3.7 is first version build with gcc. We don't plan to switch to gcc on 2.7 and so it doesn't affect us.
But I guess if this fix can be done easily, it would be correct to do.