Some define guards for Solaris are wrong

[kulikjak]

BPO	35550
Nosy	@gpshead, @jcea, @vstinner, @miss-islington, @kulikjak
PRs	bpo-35550 fix incorrect Solaris define guards #11275 [3.7] bpo-35550: Fix incorrect Solaris define guards (GH-11275) #11383 [3.7] bpo-35550: Fix incorrect Solaris define guards (GH-11275) #11383

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-01-09.13:13:43.951>
created_at = <Date 2018-12-21.10:08:03.393>
labels = ['3.8', 'build', '3.7']
title = 'Some define guards for Solaris are wrong'
updated_at = <Date 2019-03-29.14:23:16.368>
user = 'https://github.com/kulikjak'

bugs.python.org fields:

activity = <Date 2019-03-29.14:23:16.368>
actor = 'jcea'
assignee = 'none'
closed = True
closed_date = <Date 2019-01-09.13:13:43.951>
closer = 'vstinner'
components = ['Build']
creation = <Date 2018-12-21.10:08:03.393>
creator = 'kulikjak'
dependencies = []
files = []
hgrepos = []
issue_num = 35550
keywords = ['patch']
message_count = 6.0
messages = ['332284', '332788', '332791', '333165', '333301', '333314']
nosy_count = 5.0
nosy_names = ['gregory.p.smith', 'jcea', 'vstinner', 'miss-islington', 'kulikjak']
pr_nums = ['11275', '11383', '11383']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue35550'
versions = ['Python 3.7', 'Python 3.8']

[kulikjak]

Python source code uses on several places ifdef sun or defined(sun) without the underscores, which is not standard compliant and shouldn't be used. Our recent Solaris python build ended up skipping these sections resulting in some obvious problems.

Defines should check for __sun instead.

(link: http://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_system#Solaris)

[gpshead]

New changeset 6f9bc72 by Gregory P. Smith (Jakub Kulík) in branch 'master':
bpo-35550: Fix incorrect Solaris define guards (GH-11275)
6f9bc72

[miss-islington]

New changeset d823443 by Miss Islington (bot) in branch '3.7':
bpo-35550: Fix incorrect Solaris define guards (GH-11275)
d823443

[vstinner]

Do you want to fix the 2.7 branch as well?

[kulikjak]

We are building previous versions of Python with Solaris Studio which works with define guards as they are right now. 3.7 is first version build with gcc. We don't plan to switch to gcc on 2.7 and so it doesn't affect us.

But I guess if this fix can be done easily, it would be correct to do.

[vstinner]

We don't plan to switch to gcc on 2.7 and so it doesn't affect us.

Ok. I close the issue. If anyone wants to fix 2.7, please go ahead :-)