_asynciomodule.c compiled in both pythoncore.vcxproj and _asyncio.vcxproj

[indygreg]

BPO	35642
Nosy	@zooba, @indygreg, @miss-islington
PRs	bpo-35642: Remove asynciomodule.c from pythoncore.vcxproj #11410 bpo-35642: Remove asynciomodule.c from pythoncore.vcxproj #11410 bpo-35642: Remove asynciomodule.c from pythoncore.vcxproj #11410 bpo-35642: Remove asynciomodule.c from pythoncore.vcxproj #11410 [3.7] bpo-35642: Remove asynciomodule.c from pythoncore.vcxproj (GH-11410) #11747 [3.7] bpo-35642: Remove asynciomodule.c from pythoncore.vcxproj (GH-11410) #11747 [3.7] bpo-35642: Remove asynciomodule.c from pythoncore.vcxproj (GH-11410) #11747

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/zooba'
closed_at = <Date 2019-02-03.01:02:25.983>
created_at = <Date 2019-01-02.18:05:51.470>
labels = ['3.8', 'type-feature', '3.7', 'build']
title = '_asynciomodule.c compiled in both pythoncore.vcxproj and _asyncio.vcxproj'
updated_at = <Date 2019-02-03.01:02:25.983>
user = 'https://github.com/indygreg'

bugs.python.org fields:

activity = <Date 2019-02-03.01:02:25.983>
actor = 'steve.dower'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2019-02-03.01:02:25.983>
closer = 'steve.dower'
components = ['Build']
creation = <Date 2019-01-02.18:05:51.470>
creator = 'indygreg'
dependencies = []
files = []
hgrepos = []
issue_num = 35642
keywords = ['patch', 'patch', 'patch', 'patch']
message_count = 3.0
messages = ['332887', '333194', '334781']
nosy_count = 3.0
nosy_names = ['steve.dower', 'indygreg', 'miss-islington']
pr_nums = ['11410', '11410', '11410', '11410', '11747', '11747', '11747']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue35642'
versions = ['Python 3.7', 'Python 3.8']

[indygreg]

The _asynciomodule.c source file is compiled as part of both pythoncore.vcxproj (providing pythonXY.dll) and _asyncio.vcxproj (providing _asyncio.pyd).

PC\config.c doesn't reference PyInit__asyncio. I'm inclined to believe that _asynciomodule.c being built as part of pythoncore.vcxproj is a mistake.

If all goes according to plan, I will contribute my first CPython patch with a fix shortly...

[zooba]

New changeset fbf5068 by Steve Dower (Gregory Szorc) in branch 'master':
bpo-35642: Remove asynciomodule.c from pythoncore.vcxproj (GH-11410)
fbf5068

[miss-islington]

New changeset cba16b7 by Miss Islington (bot) in branch '3.7':
bpo-35642: Remove asynciomodule.c from pythoncore.vcxproj (GH-11410)
cba16b7