Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid format specifiers in MatchObject and StdPrinter repr #80432

Closed
sth mannequin opened this issue Mar 9, 2019 · 4 comments
Closed

Invalid format specifiers in MatchObject and StdPrinter repr #80432

sth mannequin opened this issue Mar 9, 2019 · 4 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-regex type-bug An unexpected behavior, bug, or error

Comments

@sth
Copy link
Mannequin

sth mannequin commented Mar 9, 2019

BPO 36251
Nosy @ezio-melotti, @sth, @serhiy-storchaka, @miss-islington
PRs
  • bpo-36251: Fix format strings used in match_repr() and stdprinter_repr() #12252
  • [3.7] bpo-36251: Fix format strings used in match_repr() and stdprinter_repr(). (GH-12252) #12263
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2019-03-10.10:56:34.954>
    created_at = <Date 2019-03-09.16:53:01.824>
    labels = ['expert-regex', 'interpreter-core', '3.8', 'type-bug', '3.7']
    title = 'Invalid format specifiers in MatchObject and StdPrinter repr'
    updated_at = <Date 2019-03-10.10:56:34.953>
    user = 'https://github.com/sth'

    bugs.python.org fields:

    activity = <Date 2019-03-10.10:56:34.953>
    actor = 'serhiy.storchaka'
    assignee = 'none'
    closed = True
    closed_date = <Date 2019-03-10.10:56:34.954>
    closer = 'serhiy.storchaka'
    components = ['Interpreter Core', 'Regular Expressions']
    creation = <Date 2019-03-09.16:53:01.824>
    creator = 'sth'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 36251
    keywords = ['patch']
    message_count = 4.0
    messages = ['337574', '337604', '337607', '337608']
    nosy_count = 5.0
    nosy_names = ['ezio.melotti', 'mrabarnett', 'sth', 'serhiy.storchaka', 'miss-islington']
    pr_nums = ['12252', '12263']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue36251'
    versions = ['Python 3.7', 'Python 3.8']

    @sth
    Copy link
    Mannequin Author

    sth mannequin commented Mar 9, 2019

    match_repr() and stdprinter_repr() contain calls to PyUnicode_FromFormat() with format specifiers that don't match the arguments.

    See the upcoming pull request for details.

    @sth sth mannequin added 3.7 (EOL) end of life 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-regex labels Mar 9, 2019
    @serhiy-storchaka
    Copy link
    Member

    New changeset 8b91eda by Serhiy Storchaka (sth) in branch 'master':
    bpo-36251: Fix format strings used in match_repr() and stdprinter_repr(). (GH-12252)
    8b91eda

    @miss-islington
    Copy link
    Contributor

    New changeset e4be205 by Miss Islington (bot) in branch '3.7':
    bpo-36251: Fix format strings used in match_repr() and stdprinter_repr(). (GH-12252)
    e4be205

    @serhiy-storchaka
    Copy link
    Member

    Thank you for your contribution Stephan!

    Versions older than 3.6 take only security fixes.

    See also bpo-36254.

    @serhiy-storchaka serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Mar 10, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-regex type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants