Remove fgBg param of idlelib.config.GetHighlight()

[terryjreedy]

BPO	36396
Nosy	@terryjreedy, @miss-islington
PRs	bpo-36396: Remove fgBg param of idlelib.config.GetHighlight() #12491 [3.7] bpo-36396: Remove fgBg param of idlelib.config.GetHighlight() (GH-12491) #12501

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2019-03-22.23:17:05.210>
created_at = <Date 2019-03-22.02:39:03.650>
labels = ['3.8', 'expert-IDLE', 'type-feature', '3.7']
title = 'Remove fgBg param of idlelib.config.GetHighlight()'
updated_at = <Date 2019-03-22.23:17:05.210>
user = 'https://github.com/terryjreedy'

bugs.python.org fields:

activity = <Date 2019-03-22.23:17:05.210>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2019-03-22.23:17:05.210>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2019-03-22.02:39:03.650>
creator = 'terry.reedy'
dependencies = []
files = []
hgrepos = []
issue_num = 36396
keywords = ['patch']
message_count = 4.0
messages = ['338580', '338585', '338619', '338620']
nosy_count = 2.0
nosy_names = ['terry.reedy', 'miss-islington']
pr_nums = ['12491', '12501']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue36396'
versions = ['Python 3.7', 'Python 3.8']

[terryjreedy]

The fgBg param of idlelib.config.GetHighlight() is used in only one idlelib call. Two other places could use it, but instead subscript the returned dict. Remove the parameter, make the function always return a dict and not a color, and have the one fgBg call use a subscript.

[terryjreedy]

There were two uses in IDLE and a few in the tests.

[terryjreedy]

New changeset c141957 by Terry Jan Reedy in branch 'master':
bpo-36396: Remove fgBg param of idlelib.config.GetHighlight() (GH-12491)
c141957

[miss-islington]

New changeset 2d7798a by Miss Islington (bot) in branch '3.7':
bpo-36396: Remove fgBg param of idlelib.config.GetHighlight() (GH-12491)
2d7798a