more helpful diagnostics for parser module

[tyomitch]

BPO	36440
Nosy	@freddrake, @brettcannon, @gpshead, @benjaminp, @berkerpeksag, @serhiy-storchaka, @tyomitch, @pablogsal
PRs	bpo-36440: include node names in ParserError messages, instead of numeric IDs #12565 [3.7] bpo-36440: include node names in ParserError messages, instead of numeric IDs (GH-12565) #12671

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-04-03.18:35:34.402>
created_at = <Date 2019-03-26.15:33:28.777>
labels = ['extension-modules', 'type-feature', '3.8']
title = 'more helpful diagnostics for parser module'
updated_at = <Date 2019-04-06.07:47:33.630>
user = 'https://github.com/tyomitch'

bugs.python.org fields:

activity = <Date 2019-04-06.07:47:33.630>
actor = 'xcombelle'
assignee = 'none'
closed = True
closed_date = <Date 2019-04-03.18:35:34.402>
closer = 'pablogsal'
components = ['Extension Modules']
creation = <Date 2019-03-26.15:33:28.777>
creator = 'A. Skrobov'
dependencies = []
files = []
hgrepos = []
issue_num = 36440
keywords = ['patch']
message_count = 11.0
messages = ['338897', '338899', '338900', '338901', '338902', '339378', '339412', '339413', '339414', '339416', '339527']
nosy_count = 9.0
nosy_names = ['fdrake', 'brett.cannon', 'gregory.p.smith', 'benjamin.peterson', 'python-dev', 'berker.peksag', 'serhiy.storchaka', 'A. Skrobov', 'pablogsal']
pr_nums = ['12565', '12671']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue36440'
versions = ['Python 3.8']

[tyomitch]

Seeing that the implicit resolution at bpo-36256 was to keep the parser module in place, may I suggest that the diagnostics it produces be improved, so that instead of "Expected node type 305, got 11", it would raise "Expected namedexpr_test, got COLON"

[pablogsal]

Thank you very much for creating the issue :)

Seeing that the implicit resolution at bpo-36256 was to keep the parser module in place

Nothing was really "decided", just that meanwhile is better not to ship a broken parser module.

may I suggest that the diagnostics it produces be improved, so that instead of "Expected node type 305, got 11", it would raise "Expected namedexpr_test, got COLON"

Would you like to produce a PR for this?

[pablogsal]

Haha, you were faster creating the PR than me posting the message!

[tyomitch]

Nothing was really "decided", just that meanwhile is better not to ship a broken parser module.

Totally true, but the issue is closed and resolved, meaning that no one will ever look at it again.

[pablogsal]

Meaning that no one will ever look at it again.

I am very interested in a better alternative to the parser module, so I will open soon another issue for that matter. But as the original issue was about a specific bug, I prefer to mark it as resolved :)

[pablogsal]

New changeset cb0748d by Pablo Galindo (tyomitch) in branch 'master':
bpo-36440: include node names in ParserError messages, instead of numeric IDs (GH-12565)
cb0748d

[pablogsal]

New changeset 513d142 by Pablo Galindo in branch '3.7':
[3.7] bpo-36440: include node names in ParserError messages, instead of numeric IDs (GH-12565) (GH-12671)
513d142

[pablogsal]

Thanks A. Skrobov for your contribution! :)

[serhiy-storchaka]

Why was this merged in 3.7? This is a new feature, not a bug fix.

[pablogsal]

Issue bpo-36256 (a real bug) was backported to 3.7 but also includes a similar improvement regarding node names in error messages. I can revert it from 3.7 if you consider it should not be there.

[serhiy-storchaka]

Since the parser module did not work in 3.7, I think this will not harm. But in general new features (including changes in error messages) are added only in the developed version.