You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
assignee=Noneclosed_at=<Date2019-04-29.09:23:39.689>created_at=<Date2019-03-29.19:26:20.924>labels= ['interpreter-core', 'type-bug', '3.8']
title='PyEval_AcquireLock() and PyEval_AcquireThread() do not handle runtime finalization properly.'updated_at=<Date2020-03-09.10:53:27.812>user='https://github.com/ericsnowcurrently'
Daemon threads keep running until they finish or until finalization starts. For the latter, there is a check right after the thread acquires the GIL which causes the thread to exit if runtime finalization has started.  However, there are functions in the C-API that facilitate acquiring the GIL, but do not cause the thread to exit during finalization:
Daemon threads that acquire the GIL through these can cause a deadlock during finalization. (See issue bpo-36469.) They should probably be updated to match what PyEval_RestoreThread() does.
 see PyEval_RestoreThread() and the eval loop, in PyEval_EvalFrameEx()
I am not comfortable to backport this change to Python 3.7. It's too early to know how it will impact applications and how many complains we will get :-) If someone really wants to backport this scary change to 3.7, I would suggest to wait for 1 month after Python 3.8.0 final release.