imaplib test fails with errno 101

[decaz]

BPO	36629
Nosy	@warsaw, @vstinner, @bitdancer, @decaz, @tirkarthi
PRs	bpo-36629: Add support.get_socket_conn_refused_errs() #12834 [3.7] bpo-36629: Add support.get_socket_conn_refused_errs() (GH-12834) #12835

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-04-15.12:15:14.611>
created_at = <Date 2019-04-14.14:34:01.292>
labels = ['3.7', 'type-bug', 'tests']
title = 'imaplib test fails with errno 101'
updated_at = <Date 2019-04-15.12:18:18.743>
user = 'https://github.com/decaz'

bugs.python.org fields:

activity = <Date 2019-04-15.12:18:18.743>
actor = 'decaz'
assignee = 'none'
closed = True
closed_date = <Date 2019-04-15.12:15:14.611>
closer = 'vstinner'
components = ['Tests']
creation = <Date 2019-04-14.14:34:01.292>
creator = 'decaz'
dependencies = []
files = []
hgrepos = []
issue_num = 36629
keywords = ['patch']
message_count = 7.0
messages = ['340212', '340214', '340215', '340256', '340258', '340267', '340268']
nosy_count = 5.0
nosy_names = ['barry', 'vstinner', 'r.david.murray', 'decaz', 'xtreak']
pr_nums = ['12834', '12835']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue36629'
versions = ['Python 3.7']

[decaz]

======================================================================
FAIL: test_imap4_host_default_value (test.test_imaplib.TestImaplib)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/home/python/Lib/test/test_imaplib.py", line 94, in test_imap4_host_default_value
    self.assertIn(cm.exception.errno, expected_errnos)
AssertionError: 101 not found in [111, 99]

---

I guess errno.ENETUNREACH should be added to the expected_errnos as it done within test_create_connection (test.test_socket.NetworkConnectionNoServer).

[tirkarthi]

Did you see this failure somewhere in CI or is it in local machine? The imaplib test has below comment :

if hasattr(errno, 'EADDRNOTAVAIL'):
    # socket.create_connection() fails randomly with
    # EADDRNOTAVAIL on Travis CI.
    expected_errnos.append(errno.EADDRNOTAVAIL)

As noted in initial report test_socket has ENETUNREACH added

cpython/Lib/test/test_socket.py

Line 4808 in 929b704

if hasattr(errno, 'ENETUNREACH'):

so ENETUNREACH could also be added to this test too?

[decaz]

I see this error on my local Bamboo CI (runs on CentOS 7).

[vstinner]

New changeset 3c7931e by Victor Stinner in branch 'master':
bpo-36629: Add support.get_socket_conn_refused_errs() (GH-12834)
3c7931e

[vstinner]

New changeset 28ed39e by Victor Stinner (Miss Islington (bot)) in branch '3.7':
bpo-36629: Add support.get_socket_conn_refused_errs() (GH-12834) (GH-12835)
28ed39e

[vstinner]

Thanks for your bug report Marat Sharafutdinov, it's now fixed in 3.7 and master (Python 2.7 is not affected, it doesn't have the test_imaplib test method).

[decaz]

Thank you for the patch, Victor!