Tools/scripts/setup.py is missing

[xdegaye]

BPO	36747
Nosy	@vstinner, @xdegaye, @berkerpeksag
PRs	bpo-36747: Remove the stale scriptsinstall Makefile target #13003

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-04-29.09:03:29.320>
created_at = <Date 2019-04-28.20:24:38.782>
labels = ['type-bug', '3.8', 'build']
title = 'Tools/scripts/setup.py is missing'
updated_at = <Date 2019-04-29.09:03:29.318>
user = 'https://github.com/xdegaye'

bugs.python.org fields:

activity = <Date 2019-04-29.09:03:29.318>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2019-04-29.09:03:29.320>
closer = 'vstinner'
components = ['Build']
creation = <Date 2019-04-28.20:24:38.782>
creator = 'xdegaye'
dependencies = []
files = []
hgrepos = []
issue_num = 36747
keywords = ['patch']
message_count = 5.0
messages = ['341035', '341036', '341048', '341056', '341057']
nosy_count = 3.0
nosy_names = ['vstinner', 'xdegaye', 'berker.peksag']
pr_nums = ['13003']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue36747'
versions = ['Python 3.8']

[xdegaye]

The 'scriptsinstall' Makefile target runs the $(srcdir)/Tools/scripts/setup.py script that does not exist anymore. It has been removed by changeset d3f467a (found after running 'cd Tools/scripts/ && git log --diff-filter=D --summary .'). Its content was then:

from distutils.core import setup

if __name__ == '__main__':
    setup(
      scripts=[
        'byteyears.py',
        'checkpyc.py',
        'copytime.py',
        'crlf.py',
        'dutree.py',
        'ftpmirror.py',
        'h2py.py',
        'lfcr.py',
        '../i18n/pygettext.py',
        'logmerge.py',
        '../../Lib/tabnanny.py',
        '../../Lib/timeit.py',
        'untabify.py',
        ],
      )

[berkerpeksag]

IMO, it would be better if we just remove the scriptsinstall target.

[xdegaye]

Agreed.

[vstinner]

New changeset 7a5a1cf by Victor Stinner (xdegaye) in branch 'master':
bpo-36747: Remove the stale scriptsinstall Makefile target (GH-13003)
7a5a1cf

[vstinner]

The broken scriptsinstall Makefile target of Python 3.7 doesn't hurt. I suggest to leave it, it's not used by any other target. I prefer to not backport the change just to avoid any risk of regression.

Thanks Xavier for the fix.