-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't log OSError exceptions in asyncio transports #81216
Comments
Currently asyncio uses There is a list of exceptions that are not logged: BrokenPipeError, Later ssl.SSLCertVerificationError was added. There is a request to skip TimeoutError as well: bpo-34148 aiohttp has a bug report about logging SSLError: aio-libs/aiohttp#3535 I am pretty sure that the network subsystem can raise other exceptions that users don't want to see in logs. I suggest changing suppression logic to skip logging of *all* OSError exceptions and eliminate _FATAL_ERROR_IGNORE list. Note, the list now contains OSError derived exceptions only, both TimeoutError and SSLError falls into this category too. Not-logged exceptions are not skipped but reported to the user by protocol.connection_lost(exc) callback. The fix is very simple, and don't change application logic. |
Update. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: