Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/test artifacts not ignored for framework build #81225

Open
jaraco opened this issue May 25, 2019 · 2 comments
Open

Build/test artifacts not ignored for framework build #81225

jaraco opened this issue May 25, 2019 · 2 comments
Labels
OS-mac type-bug An unexpected behavior, bug, or error

Comments

@jaraco
Copy link
Member

jaraco commented May 25, 2019

BPO 37044
Nosy @warsaw, @ronaldoussoren, @jaraco, @ned-deily

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2019-05-25.13:58:32.171>
labels = ['OS-mac', 'type-bug']
title = 'Build/test artifacts not ignored for framework build'
updated_at = <Date 2019-05-25.20:50:27.707>
user = 'https://github.com/jaraco'

bugs.python.org fields:

activity = <Date 2019-05-25.20:50:27.707>
actor = 'ned.deily'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['macOS']
creation = <Date 2019-05-25.13:58:32.171>
creator = 'jaraco'
dependencies = []
files = []
hgrepos = []
issue_num = 37044
keywords = []
message_count = 2.0
messages = ['343479', '343509']
nosy_count = 4.0
nosy_names = ['barry', 'ronaldoussoren', 'jaraco', 'ned.deily']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue37044'
versions = []

@jaraco
Copy link
Member Author

jaraco commented May 25, 2019

When developing on macOS, after some build/test operations (I'm not sure exactly which, but seemingly relating to a framework build), artifacts are generated which aren't ignored. As a result, it's easy for them to leak into a merge request as they did with #56756 (bpo-34632).

For example:

cpython master $ ./configure --enable-framework=/Users/jaraco/Library/Frameworks && make
...
cpython master $ git status                                                                                                                                                    
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)

        Mac/Resources/app/Info.plist
        Mac/Resources/framework/Info.plist
        Python.framework/Python
        Python.framework/Versions/

nothing added to commit but untracked files present (use "git add" to track)

(also Python.framework/Resources/, except that's in the repo at the moment, the reason for reporting this issue)

Is there not a reason to ignore these artifacts so they don't risk being added to the commit?

@jaraco jaraco added OS-mac type-bug An unexpected behavior, bug, or error labels May 25, 2019
@ned-deily
Copy link
Member

ned-deily commented May 25, 2019

That seems like a reasonable request. We should also check that the Makfile clean* rules do the right thing. One potential complication: the framework name is specified by the ./configure --with-framework-name= parameter, so it may not always be "Python.framework", the default value.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS-mac type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

2 participants