Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_gdb's test_pycfunction should test all calling conventions #81271

Closed
encukou opened this issue May 29, 2019 · 2 comments
Closed

test_gdb's test_pycfunction should test all calling conventions #81271

encukou opened this issue May 29, 2019 · 2 comments
Assignees
Labels

Comments

@encukou
Copy link
Member

encukou commented May 29, 2019

BPO 37090
Nosy @encukou
PRs
  • bpo-37090: Expand test_gdb.test_pycfunction #13668
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/encukou'
    closed_at = <Date 2019-09-12.14:38:12.021>
    created_at = <Date 2019-05-29.21:38:35.584>
    labels = ['3.8']
    title = "test_gdb's test_pycfunction should test all calling conventions"
    updated_at = <Date 2019-09-12.14:38:12.020>
    user = 'https://github.com/encukou'

    bugs.python.org fields:

    activity = <Date 2019-09-12.14:38:12.020>
    actor = 'petr.viktorin'
    assignee = 'petr.viktorin'
    closed = True
    closed_date = <Date 2019-09-12.14:38:12.021>
    closer = 'petr.viktorin'
    components = []
    creation = <Date 2019-05-29.21:38:35.584>
    creator = 'petr.viktorin'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 37090
    keywords = ['patch']
    message_count = 2.0
    messages = ['343927', '352181']
    nosy_count = 1.0
    nosy_names = ['petr.viktorin']
    pr_nums = ['13668']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue37090'
    versions = ['Python 3.8']

    @encukou
    Copy link
    Member Author

    encukou commented May 29, 2019

    test_gdb.StackNavigationTests.test_pycfunction checks that the GDB integration can pick up calls to C-API functions. Currently it includes the comment:

    Tested function must not be defined with METH_NOARGS or METH_O,
    otherwise call_function() doesn't call PyCFunction_Call()

    This is (now?) false; furthermore it looks like all builtin_function_or_method are discoverable.

    As the code paths for various METH_* conventions are diverging due to optimizations, we should check they continue to be covered.

    @encukou encukou added the 3.8 label May 29, 2019
    @encukou encukou self-assigned this May 29, 2019
    @encukou
    Copy link
    Member Author

    encukou commented Sep 12, 2019

    Fixed here and in https://bugs.python.org/issue37499 ( #15776 )

    @encukou encukou closed this as completed Sep 12, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant