You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
assignee=Noneclosed_at=<Date2019-09-11.13:42:08.549>created_at=<Date2019-06-12.14:20:14.678>labels= ['extension-modules', '3.8']
title='devpoll test failures on Solaris'updated_at=<Date2019-09-11.14:37:41.241>user='https://github.com/kulikjak'
test_devpoll currently ends with two failures with Python 3.8 on Solaris.
First one is wrong number of arguments to devpoll.register function (which thrown the same error as expected in 3.7 but now acts differently).
Second one is that register and modify no longer throw OverflowError when negative number is given as second argument, but rather a ValueError. I am not sure whether this is just a small semantics change or some bigger problem (documentation doesn't mention what error should be thrown).
So I fixed it in attached pull request by changing the expected thrown error but there might be other problem as well.