Update bundled pip and setuptools

[zooba]

BPO	37664
Nosy	@pfmoore, @ncoghlan, @benjaminp, @ned-deily, @methane, @ambv, @koobs, @zooba, @dstufft, @pradyunsg, @rdb, @miss-islington, @tirkarthi
PRs	bpo-37664: ensurepip bundle update #14934 [3.8] bpo-37664: Update bundled pip to 19.2.1 and setuptools to 41.0.1 (GH-14934) #14937 bpo-37664: Update regex for ignoring cache warning on some buildbots #14960 [3.8] bpo-37664: Update regex for ignoring cache warning on some buildbots (GH-14960) #14961 [3.7] bpo-37664: Update bundled pip to 19.2.1 and setuptools to 41.0.1 (GH-14934) #14963 [3.7] bpo-37664: Update regex for ignoring cache warning on some buildbots (GH-14960) #14964 bpo-37664: Update ensurepip bundled wheels, again #15482 bpo-37664: Update ensurepip bundled wheels, again #15483 [3.8] bpo-37664: Update ensurepip bundled wheels, again (GH-15483) #15528 [3.7] bpo-37664: Update ensurepip bundled wheels, again (GH-15483) #15529 [2.7] bpo-37664: Update ensurepip bundled wheels, again. (GH-15483) #16633

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-08-26.20:01:25.953>
created_at = <Date 2019-07-23.21:51:26.995>
labels = ['3.7', '3.8', '3.9', 'release-blocker']
title = 'Update bundled pip and setuptools'
updated_at = <Date 2019-10-08.01:54:08.754>
user = 'https://github.com/zooba'

bugs.python.org fields:

activity = <Date 2019-10-08.01:54:08.754>
actor = 'benjamin.peterson'
assignee = 'none'
closed = True
closed_date = <Date 2019-08-26.20:01:25.953>
closer = 'steve.dower'
components = []
creation = <Date 2019-07-23.21:51:26.995>
creator = 'steve.dower'
dependencies = []
files = []
hgrepos = []
issue_num = 37664
keywords = ['patch']
message_count = 29.0
messages = ['348356', '348388', '348389', '348392', '348403', '348404', '348407', '348433', '348492', '348499', '348501', '348502', '348508', '348509', '348510', '349909', '349918', '349931', '349941', '350366', '350369', '350426', '350541', '350545', '350556', '350562', '350564', '350565', '354158']
nosy_count = 14.0
nosy_names = ['paul.moore', 'ncoghlan', 'benjamin.peterson', 'ned.deily', 'methane', 'lukasz.langa', 'koobs', 'steve.dower', 'dstufft', 'pradyunsg', 'Marcus.Smith', 'rdb', 'miss-islington', 'xtreak']
pr_nums = ['14934', '14937', '14960', '14961', '14963', '14964', '15482', '15483', '15528', '15529', '16633']
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue37664'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']

[zooba]

Can we have a newer bundled version of pip for 3.8/3.9?

In particular, I'd really like to be able to use the new location for a pip.ini inside of sys.prefix, as it will fix the problems with "python3 -m pip" on Windows when obtained from the Store (and we want to default to --user).

[pradyunsg]

I might be doing another bugfix, for pypa/pip#6775. I don't think we've decided how to go about that issue yet.

If a week isn't too long a waiting time, I'd suggest we wait for a week and then vendor whatever is the latest at that point.

I'll be happy to file a PR, if we want to go ahead with this. :)

[zooba]

Oh that's a nasty issue... but it sounds like you're reaching some kind of agreement.

3.8b3 is scheduled for this week, so perhaps we can take the current release for now and then update it when you make the next release?

(Also Pradyun, would you like to be added to https://devguide.python.org/experts/ for pip so that you get nosied with that category? I'm happy to do that for you)

[pradyunsg]

Alrighty! Filed #59139.

(Sounds good to me. Filed a PR on devguide, adding me to the devguide: python/devguide#513)

[zooba]

New changeset 5380def by Steve Dower (Pradyun Gedam) in branch 'master':
bpo-37664: Update bundled pip to 19.2.1 and setuptools to 41.0.1 (GH-14934)
5380def

[miss-islington]

New changeset 0cdb21d by Miss Islington (bot) in branch '3.8':
bpo-37664: Update bundled pip to 19.2.1 and setuptools to 41.0.1 (GH-14934)
0cdb21d

[zooba]

Leaving this open until 3.8b4 in case we want to take another update.

[tirkarthi]

This change seems to have buildbot failure on FreeBSD 10 for master and 3.8 branch. I have opened bpo-37679 . I couldn't find any issues similar to this during previous upgrades.

https://buildbot.python.org/all/#/builders/167/builds/1380

test_with_pip (test.test_venv.EnsurePipTest) ... FAIL
======================================================================
FAIL: test_with_pip (test.test_venv.EnsurePipTest)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.x.koobs-freebsd10.nondebug/build/Lib/test/test_venv.py", line 495, in test_with_pip
    self.do_test_with_pip(False)
  File "/usr/home/buildbot/python/3.x.koobs-freebsd10.nondebug/build/Lib/test/test_venv.py", line 478, in do_test_with_pip
    self.assertEqual(err.rstrip(), "")
AssertionError: "WARNING: The directory '/.cache/pip/http[202 chars]lag." != ''
- WARNING: The directory '/.cache/pip/http' or its parent directory is not owned by the current user and the cache has been disabled. Please check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
+

---

[zooba]

Actually, we're already ignoring this message, but now it includes "WARNING: " at the start and doesn't match the existing regex. So we can just continue to ignore it.

[zooba]

New changeset b1eb20e by Steve Dower in branch 'master':
bpo-37664: Update regex for ignoring cache warning on some buildbots (GH-14960)
b1eb20e

[miss-islington]

New changeset c503390 by Miss Islington (bot) in branch '3.8':
bpo-37664: Update regex for ignoring cache warning on some buildbots (GH-14960)
c503390

[zooba]

Hey Ned, would you like a bundled pip update for 3.7? We haven't gone that far back.

[ned-deily]

Yeah, we should update 3.7, too, so people don’t keep getting the upgrade warning.

[miss-islington]

New changeset 0225d58 by Miss Islington (bot) in branch '3.7':
bpo-37664: Update regex for ignoring cache warning on some buildbots (GH-14960)
0225d58

[miss-islington]

New changeset ea0f7aa by Miss Islington (bot) in branch '3.7':
bpo-37664: Update bundled pip to 19.2.1 and setuptools to 41.0.1 (GH-14934)
ea0f7aa

[zooba]

Is pip 19.2.2 worth taking? Or are we expecting another patch this week?

[rdb]

@steve.dower It will be necessary to update to pip 19.2.3 for Python 3.8.0b4 shortly, as per:
pypa/pip#6874 (comment)

[methane]

When updating pip next time, please update setuptools too.
https://setuptools.readthedocs.io/en/latest/history.html#v41-1-0

bpo-1788: Changed compatibility fallback logic for html.unescape to avoid accessing HTMLParser.unescape when not necessary. HTMLParser.unescape is deprecated and will be removed in Python 3.9.

This is blocking bpo-37328.

[pradyunsg]

There wasn't a new setuptools release when I updated these the last time,
IIRC.

Anyway, I'll cut a new release for pip, file a new b.p.o. issue and get to
updating both of these sometime this week.

On Mon, 19 Aug 2019 at 11:20 AM, Inada Naoki <report@bugs.python.org> wrote:

Inada Naoki <songofacandy@gmail.com> added the comment:

When updating pip next time, please update setuptools too.
https://setuptools.readthedocs.io/en/latest/history.html#v41-1-0

> bpo-1788: Changed compatibility fallback logic for html.unescape to avoid
accessing HTMLParser.unescape when not necessary. HTMLParser.unescape is
deprecated and will be removed in Python 3.9.

This is blocking bpo-37328.

----------
nosy: +inada.naoki

---

Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue37664\>

---

[pradyunsg]

There's a need for a pip 19.2.3, since there's a bug in wheel tagging logic hasn't been updated for CPython 3.8's new tags. I'll be cutting that release, and filing a PR for updating bundled pip & setuptools, sometime in the next 24 hours. (I just got back from my final mid-semester exam, and really should relax for a bit)

I'm not sure whether we should mark this a release blocker.

[tirkarthi]

Added lukasz since last beta is by Monday.

[pradyunsg]

Made the release and the PR. <https://github.com/python/cpython/pull/15483\>

[zooba]

Just getting Łukasz's attention, as this pip release has a critical 3.8 fix for wheel generation (IIUC).

Pradyun - just looking for a NEWS file update in your PR to make sure we have the right version numbers listed.

[ambv]

Thanks for looping me in. Waiting for this to be merged.

[miss-islington]

New changeset 10c452b by Miss Islington (bot) (Pradyun Gedam) in branch 'master':
bpo-37664: Update ensurepip bundled wheels, again (GH-15483)
10c452b

[miss-islington]

New changeset c1c1a33 by Miss Islington (bot) (Steve Dower) in branch '3.7':
[3.7] bpo-37664: Update ensurepip bundled wheels, again (GH-15483) (GH-15529)
c1c1a33

[zooba]

New changeset 04b7507 by Steve Dower in branch '3.8':
bpo-37664: Update ensurepip bundled wheels, again (GH-15483)
04b7507

[zooba]

Going to call this complete now. If there's a reason to take another update before 3.8 releases, we should create a new issue.

[benjaminp]

New changeset e7e58fe by Benjamin Peterson in branch '2.7':
[2.7] bpo-37664: Update ensurepip bundled wheels, again (GH-16633)
e7e58fe