Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate changes from importlib_metadata 0.19 #81878

Closed
jaraco opened this issue Jul 28, 2019 · 5 comments
Closed

Incorporate changes from importlib_metadata 0.19 #81878

jaraco opened this issue Jul 28, 2019 · 5 comments
Labels
3.8 (EOL) end of life 3.9 only security fixes stdlib Python modules in the Lib dir

Comments

@jaraco
Copy link
Member

jaraco commented Jul 28, 2019

BPO 37697
Nosy @warsaw, @jaraco
PRs
  • bpo-37697: Sync with importlib_metadata 0.19 #14993
  • [3.8] bpo-37697: Sync with importlib_metadata 0.19 (GH-14993) #14995
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2019-07-28.19:46:47.727>
    created_at = <Date 2019-07-28.16:14:59.094>
    labels = ['3.8', 'library', '3.9']
    title = 'Incorporate changes from importlib_metadata 0.19'
    updated_at = <Date 2019-07-28.19:46:47.726>
    user = 'https://github.com/jaraco'

    bugs.python.org fields:

    activity = <Date 2019-07-28.19:46:47.726>
    actor = 'jaraco'
    assignee = 'none'
    closed = True
    closed_date = <Date 2019-07-28.19:46:47.727>
    closer = 'jaraco'
    components = ['Library (Lib)']
    creation = <Date 2019-07-28.16:14:59.094>
    creator = 'jaraco'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 37697
    keywords = ['patch']
    message_count = 5.0
    messages = ['348581', '348582', '348586', '348587', '348588']
    nosy_count = 2.0
    nosy_names = ['barry', 'jaraco']
    pr_nums = ['14993', '14995']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue37697'
    versions = ['Python 3.8', 'Python 3.9']

    @jaraco
    Copy link
    Member Author

    jaraco commented Jul 28, 2019

    Importlib_metadata 0.19 is about to release. Let's sync the code with that milestone (https://gitlab.com/python-devs/importlib_metadata/-/milestones/20).

    @jaraco jaraco added 3.8 (EOL) end of life 3.9 only security fixes stdlib Python modules in the Lib dir labels Jul 28, 2019
    @jaraco
    Copy link
    Member Author

    jaraco commented Jul 28, 2019

    I've started work on this in jaraco@ee913fd, but two tests are failing:

    ======================================================================
    FAIL: test_egg_info (test.test_importlib.test_main.DirectoryTest)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
      File "/Users/jaraco/code/public/cpython/Lib/test/test_importlib/test_main.py", line 172, in test_egg_info
        version('unknown-package')
    AssertionError: PackageNotFoundError not raised

    ======================================================================
    FAIL: test_zip_version_does_not_match (test.test_importlib.test_zip.TestEgg)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
      File "/Users/jaraco/code/public/cpython/Lib/test/test_importlib/test_zip.py", line 29, in test_zip_version_does_not_match
        version('definitely-not-installed')
    AssertionError: PackageNotFoundError not raised

    @jaraco
    Copy link
    Member Author

    jaraco commented Jul 28, 2019

    Okay, I think the issue was that I had failed to make regen-importlib. After doing that, the tests are passing. PR incoming.

    @jaraco
    Copy link
    Member Author

    jaraco commented Jul 28, 2019

    New changeset 049460d by Jason R. Coombs in branch 'master':
    bpo-37697: Sync with importlib_metadata 0.19 (bpo-14993)
    049460d

    @jaraco
    Copy link
    Member Author

    jaraco commented Jul 28, 2019

    New changeset f96334c by Jason R. Coombs (Miss Islington (bot)) in branch '3.8':
    bpo-37697: Sync with importlib_metadata 0.19 (GH-14993) (GH-14995)
    f96334c

    @jaraco jaraco closed this as completed Jul 28, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 (EOL) end of life 3.9 only security fixes stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant