Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip individual unit tests that are expensive for the PGO task #81888

Closed
nascheme opened this issue Jul 29, 2019 · 3 comments
Closed

Skip individual unit tests that are expensive for the PGO task #81888

nascheme opened this issue Jul 29, 2019 · 3 comments
Labels
build The build process and cross-build type-feature A feature request or enhancement

Comments

@nascheme
Copy link
Member

BPO 37707
Nosy @nascheme
PRs
  • bpo-37707: Exclude expensive unit tests from PGO task #15009
  • [3.8] bpo-37707: Exclude expensive unit tests from PGO task (GH-15009) #15024
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2019-07-30.18:12:56.420>
    created_at = <Date 2019-07-29.18:34:07.203>
    labels = ['type-feature', 'build']
    title = 'Skip individual unit tests that are expensive for the PGO task'
    updated_at = <Date 2019-07-30.18:34:48.942>
    user = 'https://github.com/nascheme'

    bugs.python.org fields:

    activity = <Date 2019-07-30.18:34:48.942>
    actor = 'nascheme'
    assignee = 'none'
    closed = True
    closed_date = <Date 2019-07-30.18:12:56.420>
    closer = 'nascheme'
    components = ['Build']
    creation = <Date 2019-07-29.18:34:07.203>
    creator = 'nascheme'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 37707
    keywords = ['patch']
    message_count = 3.0
    messages = ['348677', '348763', '348767']
    nosy_count = 1.0
    nosy_names = ['nascheme']
    pr_nums = ['15009', '15024']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue37707'
    versions = []

    @nascheme
    Copy link
    Member Author

    Add a new support decorator, @skip_if_pgo_task and then use it to mark test cases. I suspect the PGO task works well if it can exercise common code paths. Running long tests likely have rapidly diminishing benefits. The instrumented PGO executable runs quite a bit slower than a normal build and so it is useful to spend a bit of time to exclude expensive tests.

    @nascheme nascheme added build The build process and cross-build type-feature A feature request or enhancement labels Jul 29, 2019
    @nascheme
    Copy link
    Member Author

    New changeset 52a48e6 by Neil Schemenauer in branch 'master':
    bpo-37707: Exclude expensive unit tests from PGO task (GH-15009)
    52a48e6

    @nascheme
    Copy link
    Member Author

    New changeset 382cb85 by Neil Schemenauer (Miss Islington (bot)) in branch '3.8':
    bpo-37707: Exclude expensive unit tests from PGO task (GH-15009) (bpo-15024)
    382cb85

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    build The build process and cross-build type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant