"make clean" should remove PGO task data

[nascheme]

BPO	37725
Nosy	@nascheme, @DinoV
PRs	bpo-37725: have "make clean" remove PGO task data #15033

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-09-30.20:47:35.672>
created_at = <Date 2019-07-30.23:23:49.626>
labels = ['type-feature', 'build']
title = '"make clean" should remove PGO task data'
updated_at = <Date 2019-09-30.20:47:35.672>
user = 'https://github.com/nascheme'

bugs.python.org fields:

activity = <Date 2019-09-30.20:47:35.672>
actor = 'nascheme'
assignee = 'none'
closed = True
closed_date = <Date 2019-09-30.20:47:35.672>
closer = 'nascheme'
components = ['Build']
creation = <Date 2019-07-30.23:23:49.626>
creator = 'nascheme'
dependencies = []
files = []
hgrepos = []
issue_num = 37725
keywords = ['patch']
message_count = 2.0
messages = ['348773', '351602']
nosy_count = 2.0
nosy_names = ['nascheme', 'dino.viehland']
pr_nums = ['15033']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue37725'
versions = []

[nascheme]

I find it annoying and surprising that "make clean" does not remove the PGO data. If you change a source file, running "make clean" and "make" should result in a newly built executable, IMHO. As it is now, you usually get a confusing build failure (PGO data is out of date).

The fix is fairly easy. Make a new target that does what "clean" currently does. Have the PGO build call that when it needs to preserve the PGO data. Introduce a new "clean" target that does what the old clean did and also removes the PGO data.

Changing the build system is fraught with danger but I think this is a fairly safe change. The current behavior is quite annoying, IMHO.

[DinoV]

New changeset c6bbcd2 by Dino Viehland (Neil Schemenauer) in branch 'master':
bpo-37725: have "make clean" remove PGO task data (bpo-15033)
c6bbcd2