Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDLE: Completion window misplaced when shown above current line #82030

Closed
taleinat opened this issue Aug 14, 2019 · 7 comments
Closed

IDLE: Completion window misplaced when shown above current line #82030

taleinat opened this issue Aug 14, 2019 · 7 comments
Assignees
Labels
3.7 only security fixes 3.8 only security fixes 3.9 only security fixes topic-IDLE type-bug An unexpected behavior, bug, or error

Comments

@taleinat
Copy link
Contributor

BPO 37849
Nosy @terryjreedy, @taleinat, @miss-islington
PRs
  • bpo-37849: IDLE: fix completion window positioning above line #15267
  • [3.8] bpo-37849: IDLE: fix completion window positioning above line (GH-15267) #15282
  • [3.7] bpo-37849: IDLE: fix completion window positioning above line (GH-15267) #15283
  • Files
  • idle_completion_window_position.png
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
    closed_at = <Date 2020-09-19.19:22:07.434>
    created_at = <Date 2019-08-14.06:40:49.632>
    labels = ['3.8', 'expert-IDLE', 'type-bug', '3.7', '3.9']
    title = 'IDLE: Completion window misplaced when shown above current line'
    updated_at = <Date 2020-09-19.19:22:07.434>
    user = 'https://github.com/taleinat'

    bugs.python.org fields:

    activity = <Date 2020-09-19.19:22:07.434>
    actor = 'taleinat'
    assignee = 'terry.reedy'
    closed = True
    closed_date = <Date 2020-09-19.19:22:07.434>
    closer = 'taleinat'
    components = ['IDLE']
    creation = <Date 2019-08-14.06:40:49.632>
    creator = 'taleinat'
    dependencies = []
    files = ['48541']
    hgrepos = []
    issue_num = 37849
    keywords = ['patch']
    message_count = 7.0
    messages = ['349652', '349654', '349657', '349662', '349717', '349719', '349722']
    nosy_count = 3.0
    nosy_names = ['terry.reedy', 'taleinat', 'miss-islington']
    pr_nums = ['15267', '15282', '15283']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue37849'
    versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']

    @taleinat
    Copy link
    Contributor Author

    When the current line is near the bottom of the shell window, the completions list will be shown above it. However, instead of appearing directly above the current line, it appears quite a bit higher, about one line too high. See attached screenshot.

    Seen on Windows 10 with current master (2a570af).

    First brought up by Terry Reedy in a comment on PR #59374 [1].

    [1] #15169 (comment)

    @taleinat taleinat added 3.7 only security fixes 3.8 only security fixes 3.9 only security fixes labels Aug 14, 2019
    @taleinat
    Copy link
    Contributor Author

    See PR #59472 with a fix.

    @terryjreedy
    Copy link
    Member

    What I reported is that it is too low on my Windows system, with my size and font, mostly covering the line. Anyway, misplaced before, now perfectly placed.

    Now that I see the patch, I seem to remember another place what an update call is needed before gathering window information.

    Unless you say differently, I will add idlelib/NEWS.txt item tomorrow and merge.

    @taleinat
    Copy link
    Contributor Author

    Unless you say differently, I will add idlelib/NEWS.txt item tomorrow and merge.

    I've added an idlelib/NEWS.txt entry to the PR. Feel free to merge.

    @terryjreedy
    Copy link
    Member

    New changeset 71662dc by Terry Jan Reedy (Tal Einat) in branch 'master':
    bpo-37849: IDLE: fix completion window positioning above line (GH-15267)
    71662dc

    @miss-islington
    Copy link
    Contributor

    New changeset 557802d by Miss Islington (bot) in branch '3.8':
    bpo-37849: IDLE: fix completion window positioning above line (GH-15267)
    557802d

    @miss-islington
    Copy link
    Contributor

    New changeset 88cce7b by Miss Islington (bot) in branch '3.7':
    bpo-37849: IDLE: fix completion window positioning above line (GH-15267)
    88cce7b

    @taleinat taleinat added the type-bug An unexpected behavior, bug, or error label Sep 19, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 only security fixes 3.8 only security fixes 3.9 only security fixes topic-IDLE type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants