IDLE: Completion window misplaced when shown above current line

[taleinat]

BPO	37849
Nosy	@terryjreedy, @taleinat, @miss-islington
PRs	bpo-37849: IDLE: fix completion window positioning above line #15267 [3.8] bpo-37849: IDLE: fix completion window positioning above line (GH-15267) #15282 [3.7] bpo-37849: IDLE: fix completion window positioning above line (GH-15267) #15283
Files	idle_completion_window_position.png

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2020-09-19.19:22:07.434>
created_at = <Date 2019-08-14.06:40:49.632>
labels = ['3.8', 'expert-IDLE', 'type-bug', '3.7', '3.9']
title = 'IDLE: Completion window misplaced when shown above current line'
updated_at = <Date 2020-09-19.19:22:07.434>
user = 'https://github.com/taleinat'

bugs.python.org fields:

activity = <Date 2020-09-19.19:22:07.434>
actor = 'taleinat'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2020-09-19.19:22:07.434>
closer = 'taleinat'
components = ['IDLE']
creation = <Date 2019-08-14.06:40:49.632>
creator = 'taleinat'
dependencies = []
files = ['48541']
hgrepos = []
issue_num = 37849
keywords = ['patch']
message_count = 7.0
messages = ['349652', '349654', '349657', '349662', '349717', '349719', '349722']
nosy_count = 3.0
nosy_names = ['terry.reedy', 'taleinat', 'miss-islington']
pr_nums = ['15267', '15282', '15283']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue37849'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']

[taleinat]

When the current line is near the bottom of the shell window, the completions list will be shown above it. However, instead of appearing directly above the current line, it appears quite a bit higher, about one line too high. See attached screenshot.

Seen on Windows 10 with current master (2a570af).

First brought up by Terry Reedy in a comment on PR #59374 [1].

[1] #15169 (comment)

[taleinat]

See PR #59472 with a fix.

[terryjreedy]

What I reported is that it is too low on my Windows system, with my size and font, mostly covering the line. Anyway, misplaced before, now perfectly placed.

Now that I see the patch, I seem to remember another place what an update call is needed before gathering window information.

Unless you say differently, I will add idlelib/NEWS.txt item tomorrow and merge.

[taleinat]

Unless you say differently, I will add idlelib/NEWS.txt item tomorrow and merge.

I've added an idlelib/NEWS.txt entry to the PR. Feel free to merge.

[terryjreedy]

New changeset 71662dc by Terry Jan Reedy (Tal Einat) in branch 'master':
bpo-37849: IDLE: fix completion window positioning above line (GH-15267)
71662dc

[miss-islington]

New changeset 557802d by Miss Islington (bot) in branch '3.8':
bpo-37849: IDLE: fix completion window positioning above line (GH-15267)
557802d

[miss-islington]

New changeset 88cce7b by Miss Islington (bot) in branch '3.7':
bpo-37849: IDLE: fix completion window positioning above line (GH-15267)
88cce7b