repr() of buffered and text streams silences too many exceptions

[serhiy-storchaka]

BPO	37960
Nosy	@benjaminp, @serhiy-storchaka, @miss-islington
PRs	bpo-37960: Silence only necessary errors in repr() of buffered and text streams. #15543 [3.8] bpo-37960: Silence only necessary errors in repr() of buffered and text streams. (GH-15543) #15580

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-08-29.08:14:01.458>
created_at = <Date 2019-08-27.07:49:40.349>
labels = ['3.8', 'type-bug', 'library', '3.9', 'expert-IO']
title = 'repr() of buffered and text streams silences too many exceptions'
updated_at = <Date 2019-08-29.08:14:01.457>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2019-08-29.08:14:01.457>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2019-08-29.08:14:01.458>
closer = 'serhiy.storchaka'
components = ['Library (Lib)', 'IO']
creation = <Date 2019-08-27.07:49:40.349>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 37960
keywords = ['patch']
message_count = 3.0
messages = ['350614', '350729', '350752']
nosy_count = 4.0
nosy_names = ['benjamin.peterson', 'stutzbach', 'serhiy.storchaka', 'miss-islington']
pr_nums = ['15543', '15580']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue37960'
versions = ['Python 3.8', 'Python 3.9']

[serhiy-storchaka]

__repr__() implementations of buffered and text streams try to include the value of "name" and "mode" attributes in the result. But they silence too wide range of exceptions (all subclasses of Exception) when try to get these values. This includes such exceptions as MemoryError or RecursionError which can be occurred in virtually any code.

The proposed PR narrows the range of silenced exceptions to the necessary minimum: expected AttributeError and ValueError. The latter is raised if the underlying stream was detached.

[serhiy-storchaka]

New changeset b235a1b by Serhiy Storchaka in branch 'master':
bpo-37960: Silence only necessary errors in repr() of buffered and text streams. (GH-15543)
b235a1b

[miss-islington]

New changeset 102130a by Miss Islington (bot) in branch '3.8':
bpo-37960: Silence only necessary errors in repr() of buffered and text streams. (GH-15543)
102130a