Missing constants in Lib/stat.py

[rlamy]

BPO	38109
Nosy	@pitrou, @vstinner, @rlamy, @brandtbucher
PRs	bpo-38109: Add missing constants to Lib/stat.py #16665 [3.8] bpo-38109: Add missing constants to Lib/stat.py (GH-16665) #16690 [3.7] bpo-38109: Add missing constants to Lib/stat.py (GH-16665) #16691

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-10-10.13:52:05.729>
created_at = <Date 2019-09-11.13:35:59.349>
labels = ['3.8', '3.7', 'library', '3.9']
title = 'Missing constants in Lib/stat.py'
updated_at = <Date 2019-10-10.14:08:22.705>
user = 'https://github.com/rlamy'

bugs.python.org fields:

activity = <Date 2019-10-10.14:08:22.705>
actor = 'Ronan.Lamy'
assignee = 'none'
closed = True
closed_date = <Date 2019-10-10.13:52:05.729>
closer = 'vstinner'
components = ['Library (Lib)']
creation = <Date 2019-09-11.13:35:59.349>
creator = 'Ronan.Lamy'
dependencies = []
files = []
hgrepos = []
issue_num = 38109
keywords = ['patch']
message_count = 8.0
messages = ['351870', '354320', '354321', '354372', '354374', '354375', '354376', '354380']
nosy_count = 4.0
nosy_names = ['pitrou', 'vstinner', 'Ronan.Lamy', 'brandtbucher']
pr_nums = ['16665', '16690', '16691']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue38109'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']

[rlamy]

According to the docs, stat should include constants S_IFDOOR, S_IFPORT, S_IFWHT as well as the related S_IS... functions. However, these are only defined in _stat. I know that stat is a bit special (see bpo-11016), but that goes against PEP-399.

[vstinner]

New changeset 7bb1431 by Victor Stinner (Ronan Lamy) in branch 'master':
bpo-38109: Add missing constants to Lib/stat.py (GH-16665)
7bb1431

[vstinner]

Ronan Lamy: Hum, do you really need this change to land in Python 3.7 and 3.8? If not, I will close PR 16690 and PR 16691 backports.

I don't think that it's worth it, since _stat should be always present in CPython.

[rlamy]

Well, my interest in this is to reduce the divergence between PyPy and CPython, and, potentially, to help other implementations. So I actually care more about 3.7 than about 3.9, which I probably won't look at before 2021.

That said, I don't *need* anything: the fix is already in PyPy and we'll carry it forward regardless of what CPython does.

[vstinner]

New changeset 8ab11c4 by Victor Stinner (Miss Islington (bot)) in branch '3.8':
bpo-38109: Add missing constants to Lib/stat.py (GH-16665) (GH-16690)
8ab11c4

[vstinner]

New changeset f5ed41c by Victor Stinner (Miss Islington (bot)) in branch '3.7':
bpo-38109: Add missing constants to Lib/stat.py (GH-16665) (GH-16691)
f5ed41c

[vstinner]

I understand that backporting the change up to 3.7 makes your life easier, so I merged it. The change is safe and should not affect the regular use case (when the C extension _stat is used).

Thanks Ronan for this nice enhancement. It's good to see the stat module respect the PEP-399 ;-)

[rlamy]

Thanks Victor!