-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove statics from ast.c #82294
Comments
Remove various static state from the ast module and make it PEP-384 compatible. This will help make it be more compatible w/ subinterpreters and make it re-usable by 3rd party implementations. |
Remove statics to make more compatible with subinterpreters. |
This change introduced tons of reference leaks, more than 21 test files leak references: see bpo-38152. Please fix these leaks, or I will have to revert the change: |
This change introduced a subtle regression: bpo-41194. I modified the _ast module to use again a global state: New changeset 91e1bc1 by Victor Stinner in branch 'master': I also proposed PR 21293 to use again a module state, even if the implementation has some drawbacks (see the PR comments). |
Sadly, my fix doesn't work in all cases, there is yet another bug: bpo-41631 "_ast module: get_global_ast_state() doesn't work with Mercurial lazy import". |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: