Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntpath.realpath() fails on sys.executable #82536

Closed
zooba opened this issue Oct 2, 2019 · 5 comments
Closed

ntpath.realpath() fails on sys.executable #82536

zooba opened this issue Oct 2, 2019 · 5 comments
Assignees
Labels

Comments

@zooba
Copy link
Member

zooba commented Oct 2, 2019

BPO 38355
Nosy @pfmoore, @tjguk, @ambv, @zware, @zooba, @miss-islington
PRs
  • bpo-38355: Fix ntpath.realpath failing on sys.executable #16551
  • [3.8] bpo-38355: Fix ntpath.realpath failing on sys.executable (GH-16551) #16563
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
    closed_at = <Date 2019-10-14.21:45:49.946>
    created_at = <Date 2019-10-02.22:37:37.259>
    labels = ['3.8', '3.9', 'OS-windows', 'release-blocker']
    title = 'ntpath.realpath() fails on sys.executable'
    updated_at = <Date 2019-10-14.21:45:49.944>
    user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2019-10-14.21:45:49.944>
    actor = 'lukasz.langa'
    assignee = 'steve.dower'
    closed = True
    closed_date = <Date 2019-10-14.21:45:49.946>
    closer = 'lukasz.langa'
    components = ['Windows']
    creation = <Date 2019-10-02.22:37:37.259>
    creator = 'steve.dower'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 38355
    keywords = ['patch', '3.8regression']
    message_count = 5.0
    messages = ['353782', '353855', '353861', '353863', '354667']
    nosy_count = 6.0
    nosy_names = ['paul.moore', 'tim.golden', 'lukasz.langa', 'zach.ware', 'steve.dower', 'miss-islington']
    pr_nums = ['16551', '16563']
    priority = 'release blocker'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue38355'
    versions = ['Python 3.8', 'Python 3.9']

    @zooba
    Copy link
    Member Author

    zooba commented Oct 2, 2019

    The change to error handling did not include ERROR_CANT_ACCESS_FILE, but this error occurs in the Store package install.

    After suppressing this error, it then occurs again when stripping the prefix - we should just check for the same error here to determine whether it's safe to remove the prefix of a file we can't access.

    @zooba zooba added 3.8 (EOL) end of life 3.9 only security fixes release-blocker labels Oct 2, 2019
    @zooba zooba self-assigned this Oct 2, 2019
    @zooba
    Copy link
    Member Author

    zooba commented Oct 3, 2019

    New changeset a0e3d27 by Steve Dower in branch 'master':
    bpo-38355: Fix ntpath.realpath failing on sys.executable (GH-16551)
    a0e3d27

    @miss-islington
    Copy link
    Contributor

    New changeset 6067e1d by Miss Islington (bot) in branch '3.8':
    bpo-38355: Fix ntpath.realpath failing on sys.executable (GH-16551)
    6067e1d

    @zooba
    Copy link
    Member Author

    zooba commented Oct 3, 2019

    This is resolved as far as I'm concerned - leaving open for Łukasz to cherrypick and close.

    @ambv
    Copy link
    Contributor

    ambv commented Oct 14, 2019

    (3.8.0 is released with this fix)

    @ambv ambv closed this as completed Oct 14, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants