ntpath.realpath() fails on sys.executable

[zooba]

BPO	38355
Nosy	@pfmoore, @tjguk, @ambv, @zware, @zooba, @miss-islington
PRs	bpo-38355: Fix ntpath.realpath failing on sys.executable #16551 [3.8] bpo-38355: Fix ntpath.realpath failing on sys.executable (GH-16551) #16563

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/zooba'
closed_at = <Date 2019-10-14.21:45:49.946>
created_at = <Date 2019-10-02.22:37:37.259>
labels = ['3.8', '3.9', 'OS-windows', 'release-blocker']
title = 'ntpath.realpath() fails on sys.executable'
updated_at = <Date 2019-10-14.21:45:49.944>
user = 'https://github.com/zooba'

bugs.python.org fields:

activity = <Date 2019-10-14.21:45:49.944>
actor = 'lukasz.langa'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2019-10-14.21:45:49.946>
closer = 'lukasz.langa'
components = ['Windows']
creation = <Date 2019-10-02.22:37:37.259>
creator = 'steve.dower'
dependencies = []
files = []
hgrepos = []
issue_num = 38355
keywords = ['patch', '3.8regression']
message_count = 5.0
messages = ['353782', '353855', '353861', '353863', '354667']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'lukasz.langa', 'zach.ware', 'steve.dower', 'miss-islington']
pr_nums = ['16551', '16563']
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue38355'
versions = ['Python 3.8', 'Python 3.9']

[zooba]

The change to error handling did not include ERROR_CANT_ACCESS_FILE, but this error occurs in the Store package install.

After suppressing this error, it then occurs again when stripping the prefix - we should just check for the same error here to determine whether it's safe to remove the prefix of a file we can't access.

[zooba]

New changeset a0e3d27 by Steve Dower in branch 'master':
bpo-38355: Fix ntpath.realpath failing on sys.executable (GH-16551)
a0e3d27

[miss-islington]

New changeset 6067e1d by Miss Islington (bot) in branch '3.8':
bpo-38355: Fix ntpath.realpath failing on sys.executable (GH-16551)
6067e1d

[zooba]

This is resolved as far as I'm concerned - leaving open for Łukasz to cherrypick and close.

[ambv]

(3.8.0 is released with this fix)