Internal include files missing on Windows

[zooba]

BPO	38519
Nosy	@pfmoore, @tjguk, @zware, @zooba, @ZackerySpytz, @miss-islington
PRs	bpo-38519: Internal include files missing on Windows #16921 [3.8] bpo-38519: Internal include files missing on Windows (GH-16921) #16966

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/zooba'
closed_at = <Date 2020-02-25.18:23:02.959>
created_at = <Date 2019-10-18.18:30:38.215>
labels = ['build', '3.8', '3.9', 'OS-windows']
title = 'Internal include files missing on Windows'
updated_at = <Date 2020-02-25.18:23:02.958>
user = 'https://github.com/zooba'

bugs.python.org fields:

activity = <Date 2020-02-25.18:23:02.958>
actor = 'steve.dower'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2020-02-25.18:23:02.959>
closer = 'steve.dower'
components = ['Windows']
creation = <Date 2019-10-18.18:30:38.215>
creator = 'steve.dower'
dependencies = []
files = []
hgrepos = []
issue_num = 38519
keywords = ['patch']
message_count = 5.0
messages = ['354914', '354915', '355353', '355568', '355571']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'ZackerySpytz', 'miss-islington']
pr_nums = ['16921', '16966']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue38519'
versions = ['Python 3.8', 'Python 3.9']

[zooba]

The include/internal directory is not being included in the packages published to nuget.org or the Microsoft Store.

This prevents some advanced users from being able to compile against these packages.

[zooba]

If someone wants to fix this before I do, the change goes in PC/layout/main.py to remove the filter for directories named "internal" - we shouldn't need a filter there at all now that we include everything in the distro.

[ZackerySpytz]

Hi, Steve. I've created a PR for this.

[zooba]

New changeset edb172a by Steve Dower (Zackery Spytz) in branch 'master':
bpo-38519: Internal include files missing on Windows (GH-16921)
edb172a

[miss-islington]

New changeset 07eee64 by Miss Skeleton (bot) in branch '3.8':
bpo-38519: Internal include files missing on Windows (GH-16921)
07eee64