Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore_dangling_symlinks in shutil.copytree does not apply recursively #82704

Closed
veaviticus mannequin opened this issue Oct 18, 2019 · 1 comment · Fixed by #22937
Closed

ignore_dangling_symlinks in shutil.copytree does not apply recursively #82704

veaviticus mannequin opened this issue Oct 18, 2019 · 1 comment · Fixed by #22937
Labels
3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@veaviticus
Copy link
Mannequin

veaviticus mannequin commented Oct 18, 2019

BPO 38523
Nosy @ZackerySpytz, @veaviticus
PRs
  • bpo-38523: ignore_dangling_symlinks does not apply recursively #22937
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2019-10-18.22:29:15.013>
    labels = ['type-bug', 'library', '3.9', '3.10', '3.11']
    title = 'ignore_dangling_symlinks in shutil.copytree does not apply recursively'
    updated_at = <Date 2021-12-06.20:33:30.942>
    user = 'https://github.com/veaviticus'

    bugs.python.org fields:

    activity = <Date 2021-12-06.20:33:30.942>
    actor = 'iritkatriel'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2019-10-18.22:29:15.013>
    creator = 'veaviticus'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 38523
    keywords = ['patch']
    message_count = 1.0
    messages = ['354924']
    nosy_count = 2.0
    nosy_names = ['ZackerySpytz', 'veaviticus']
    pr_nums = ['22937']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue38523'
    versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    @veaviticus
    Copy link
    Mannequin Author

    veaviticus mannequin commented Oct 18, 2019

    The ignore_dangling_symlinks attribute in shutil.copytree is not passed down recursively, resulting in dangling symlinks located anywhere other than the root of the source tree to raise an error.

    The line causing the error for 3.9: https://github.com/python/cpython/blob/v3.8.0/Lib/shutil.py#L486

    Trivial patches and an improved test case for:
    3.7: veaviticus@a662ae8

    3.8: veaviticus@64f72c7

    3.9: veaviticus@e55dd12

    @veaviticus veaviticus mannequin added 3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir labels Oct 18, 2019
    @iritkatriel iritkatriel added 3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes type-bug An unexpected behavior, bug, or error and removed 3.7 (EOL) end of life 3.8 only security fixes labels Dec 6, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    Successfully merging a pull request may close this issue.

    1 participant