Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idle completion windows should close on Escape key #83125

Closed
JohnnyNajera mannequin opened this issue Nov 30, 2019 · 5 comments
Closed

Idle completion windows should close on Escape key #83125

JohnnyNajera mannequin opened this issue Nov 30, 2019 · 5 comments
Assignees
Labels
3.7 (EOL) end of life 3.8 (EOL) end of life 3.9 only security fixes topic-IDLE type-bug An unexpected behavior, bug, or error

Comments

@JohnnyNajera
Copy link
Mannequin

JohnnyNajera mannequin commented Nov 30, 2019

BPO 38944
Nosy @terryjreedy, @miss-islington, @JohnnyNajera
PRs
  • bpo-38944: Escape key now closes IDLE completion windows. #17419
  • [3.8] bpo-38944: Escape key now closes IDLE completion windows. (GH-17419) #17546
  • [3.7] bpo-38944: Escape key now closes IDLE completion windows. (GH-17419) #17547
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
    closed_at = <Date 2019-12-09.23:50:49.164>
    created_at = <Date 2019-11-30.11:42:29.577>
    labels = ['3.8', 'expert-IDLE', 'type-bug', '3.7', '3.9']
    title = 'Idle completion windows should close on Escape key'
    updated_at = <Date 2019-12-09.23:50:49.163>
    user = 'https://github.com/JohnnyNajera'

    bugs.python.org fields:

    activity = <Date 2019-12-09.23:50:49.163>
    actor = 'terry.reedy'
    assignee = 'terry.reedy'
    closed = True
    closed_date = <Date 2019-12-09.23:50:49.164>
    closer = 'terry.reedy'
    components = ['IDLE']
    creation = <Date 2019-11-30.11:42:29.577>
    creator = 'JohnnyNajera'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 38944
    keywords = ['patch']
    message_count = 5.0
    messages = ['357658', '358149', '358151', '358152', '358153']
    nosy_count = 3.0
    nosy_names = ['terry.reedy', 'miss-islington', 'JohnnyNajera']
    pr_nums = ['17419', '17546', '17547']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue38944'
    versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']

    @JohnnyNajera
    Copy link
    Mannequin Author

    JohnnyNajera mannequin commented Nov 30, 2019

    Tested on all major Ubuntu releases.

    @JohnnyNajera JohnnyNajera mannequin added 3.7 (EOL) end of life 3.8 (EOL) end of life 3.9 only security fixes labels Nov 30, 2019
    @JohnnyNajera JohnnyNajera mannequin added the topic-IDLE label Nov 30, 2019
    @terryjreedy
    Copy link
    Member

    New changeset 232689b by Terry Jan Reedy (JohnnyNajera) in branch 'master':
    bpo-38944: Escape key now closes IDLE completion windows. (GH-17419)
    232689b

    @terryjreedy
    Copy link
    Member

    With this done, we can think about whether the behavior of <Return> should be changed (on a new issue). I need to first document what it does do in all the different situations.

    @terryjreedy terryjreedy changed the title Idle autocomplete window doesn't close on Escape key Idle completion windows should close on Escape key Dec 9, 2019
    @terryjreedy terryjreedy added the type-bug An unexpected behavior, bug, or error label Dec 9, 2019
    @miss-islington
    Copy link
    Contributor

    New changeset 2b2c7bf by Miss Islington (bot) in branch '3.8':
    bpo-38944: Escape key now closes IDLE completion windows. (GH-17419)
    2b2c7bf

    @miss-islington
    Copy link
    Contributor

    New changeset 4e0e452 by Miss Islington (bot) in branch '3.7':
    bpo-38944: Escape key now closes IDLE completion windows. (GH-17419)
    4e0e452

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 (EOL) end of life 3.9 only security fixes topic-IDLE type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants