Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTP Only flag in MozillaCookieJar #83157

Closed
jacobneiltaylor mannequin opened this issue Dec 5, 2019 · 3 comments
Closed

Add support for HTTP Only flag in MozillaCookieJar #83157

jacobneiltaylor mannequin opened this issue Dec 5, 2019 · 3 comments
Assignees
Labels
3.10 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@jacobneiltaylor
Copy link
Mannequin

jacobneiltaylor mannequin commented Dec 5, 2019

BPO 38976
Nosy @orsenthil, @dlenski, @jacobneiltaylor
PRs
  • bpo-38976: Add support for HTTP Only flag in MozillaCookieJar #17471
  • bpo-2190: make MozillaCookieJar handle HTTP-only cookies #22798
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/orsenthil'
    closed_at = <Date 2020-10-23.22:49:45.979>
    created_at = <Date 2019-12-05.05:13:43.630>
    labels = ['type-feature', 'library', '3.10']
    title = 'Add support for HTTP Only flag in MozillaCookieJar'
    updated_at = <Date 2020-11-15.20:38:00.265>
    user = 'https://github.com/jacobneiltaylor'

    bugs.python.org fields:

    activity = <Date 2020-11-15.20:38:00.265>
    actor = 'dlenski'
    assignee = 'orsenthil'
    closed = True
    closed_date = <Date 2020-10-23.22:49:45.979>
    closer = 'orsenthil'
    components = ['Library (Lib)']
    creation = <Date 2019-12-05.05:13:43.630>
    creator = 'Jacob Taylor'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 38976
    keywords = ['patch']
    message_count = 3.0
    messages = ['357837', '379487', '381033']
    nosy_count = 3.0
    nosy_names = ['orsenthil', 'dlenski', 'Jacob Taylor']
    pr_nums = ['17471', '22798']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue38976'
    versions = ['Python 3.10']

    @jacobneiltaylor
    Copy link
    Mannequin Author

    jacobneiltaylor mannequin commented Dec 5, 2019

    This PR adds support for the HttpOnly flag as encoded in CURL cookiejars.

    This PR was mainly designed to allow the MozillaCookieJar to parse in the cookies, as previously they were considered comments and ignored.

    As HttpOnly is considered a non-standard attribute, the nonstandard attribute dict was considered the most appropriate place to persist this information.

    @jacobneiltaylor jacobneiltaylor mannequin added 3.9 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Dec 5, 2019
    @orsenthil orsenthil self-assigned this Mar 31, 2020
    @orsenthil
    Copy link
    Member

    New changeset 16ee68d by Jacob Neil Taylor in branch 'master':
    bpo-38976: Add support for HTTP Only flag in MozillaCookieJar (bpo-17471)
    16ee68d

    @orsenthil orsenthil added 3.10 only security fixes and removed 3.9 only security fixes labels Oct 23, 2020
    @dlenski
    Copy link
    Mannequin

    dlenski mannequin commented Nov 15, 2020

    This issue is essentially a duplicate of the very-longstanding bpo-2190.

    My PR (#22798) was submitted before this one, but this one was accepted and merged first.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.10 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant