-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
Merge nntplib._NNTPBase and nntplib.NNTP #83486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
See: #17939 (review) There was partial refactoring through PR 17939. The only care point would be rewriting unit testing code which depends on nntplib._NNTPBase. |
Hey, I'm taking a look into this! |
Good news, if you submit the patch. |
Thank you, I am creating the patch now and will submit it later today! |
I just uploaded the PR, please take a look when you have a chance :) I did my best trying to come up with a good code. |
I am no closing this issue :) Thank you for the suggestion, Victor. |
Thanks, that's a nice simplification of the code ;-) |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: