Merge nntplib._NNTPBase and nntplib.NNTP

[corona10]

BPO	39305
Nosy	@vstinner, @corona10, @LucianaMarques
PRs	bpo-39305: Refactor nntplib.py #18045 bpo-39305: Update nntplib to merge nntplib.NNTP and nntplib._NNTPBase #19817

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-05-16.10:33:18.073>
created_at = <Date 2020-01-11.15:52:28.737>
labels = ['type-feature', 'library', '3.9']
title = 'Merge nntplib._NNTPBase and nntplib.NNTP'
updated_at = <Date 2020-05-16.15:23:15.238>
user = 'https://github.com/corona10'

bugs.python.org fields:

activity = <Date 2020-05-16.15:23:15.238>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2020-05-16.10:33:18.073>
closer = 'corona10'
components = ['Library (Lib)']
creation = <Date 2020-01-11.15:52:28.737>
creator = 'corona10'
dependencies = []
files = []
hgrepos = []
issue_num = 39305
keywords = ['patch']
message_count = 8.0
messages = ['359803', '359989', '360012', '360066', '360218', '369038', '369039', '369052']
nosy_count = 3.0
nosy_names = ['vstinner', 'corona10', 'lucianamarques']
pr_nums = ['18045', '19817']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue39305'
versions = ['Python 3.9']

[corona10]

See: #17939 (review)

There was partial refactoring through PR 17939.
I and Victor think that nntplib._NNTPBase can be removed by merging nntplib._NNTPBase and nntplib.NNTP.

The only care point would be rewriting unit testing code which depends on nntplib._NNTPBase.

[lucianamarques]

Hey, I'm taking a look into this!

[corona10]

@LucianaMarques

Good news, if you submit the patch.
Please ping me and @vstinner :)

[lucianamarques]

Thank you, I am creating the patch now and will submit it later today!

[lucianamarques]

I just uploaded the PR, please take a look when you have a chance :)

I did my best trying to come up with a good code.

[corona10]

New changeset aa92a7c by Dong-hee Na in branch 'master':
bpo-39305: Update nntplib to merge nntplib.NNTP and nntplib._NNTPBase (GH-19817)
aa92a7c

[corona10]

I am no closing this issue :)

Thank you for the suggestion, Victor.
And also thank you for the interest in this issue, Luciana :)

[vstinner]

Thanks, that's a nice simplification of the code ;-)